Timestamps on created and modified at values #3532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
reviewed
Jan 12, 2022
src/components/card/CardSidebar.vue
Outdated
| @@ -25,6 +25,7 @@ | |||
| :active="tabId" | |||
| :title="title" | |||
| :subtitle="subtitle" | |||
| :subtitleTooltip="subtitleTooltip" | |||
There was a problem hiding this comment.
Mind to fix the eslint warning?
src/components/card/CardSidebar.vue#L28
Attribute ':subtitleTooltip' must be hyphenated
|
Otherwise looks good, LGTM once linter is happy 👍 |
luka-nextcloud
force-pushed
the
feature/timestamps-on-created-and-modified-at-values
branch
2 times, most recently
from
e119f75 to
25de24d
Compare
julien-nc
requested changes
Jan 18, 2022
src/components/card/CardSidebar.vue
Outdated
| @@ -142,6 +146,9 @@ export default { | |||
| subtitle() { | |||
| return t('deck', 'Modified') + ': ' + this.relativeDate(this.currentCard.lastModified * 1000) + ' ' + t('deck', 'Created') + ': ' + this.relativeDate(this.currentCard.createdAt * 1000) | |||
| }, | |||
| subtitleTooltip() { | |||
| return t('deck', 'Modified') + ': ' + this.formatDate(new Date(this.currentCard.lastModified * 1000)) + '\n' + t('deck', 'Created') + ': ' + this.formatDate(new Date(this.currentCard.createdAt * 1000)) | |||
There was a problem hiding this comment.
Suggested change
| return t('deck', 'Modified') + ': ' + this.formatDate(new Date(this.currentCard.lastModified * 1000)) + '\n' + t('deck', 'Created') + ': ' + this.formatDate(new Date(this.currentCard.createdAt * 1000)) | |
| return t('deck', 'Modified') + ': ' + this.formatDate(this.currentCard.lastModified) + '\n' + t('deck', 'Created') + ': ' + this.formatDate(this.currentCard.createdAt) |
src/components/card/CardSidebar.vue
Outdated
Comment on lines
199
to
200
| formatDate(date) { | ||
| return moment(date).locale(this.locale).format('LLLL') |
There was a problem hiding this comment.
Suggested change
| formatDate(date) { | |
| return moment(date).locale(this.locale).format('LLLL') | |
| formatDate(timestamp) { | |
| return moment.unix(timestamp).locale(this.locale).format('LLLL') |
Signed-off-by: Luka Trovic <luka@nextcloud.com>
luka-nextcloud
force-pushed
the
feature/timestamps-on-created-and-modified-at-values
branch
from
25de24d to
054c5aa
Compare
julien-nc
approved these changes
Jan 20, 2022
delete-merged-branch
bot
deleted the
feature/timestamps-on-created-and-modified-at-values
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luka Trovic luka@nextcloud.com
Checklist