Make links in markdown note bolder #3530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luka-nextcloud
changed the title
This comment has been minimized.
This comment has been minimized.
|
Regarding the screenshot at #3443 (comment), what would be ideal is:
|
Deck is not yet using text
@luka-nextcloud Could you adjust that accordingly? Using CSS variables will have the benefit that the coolers will adjust properly when using the dark theme which can be toggled in the users accessibility settings. |
luka-nextcloud
force-pushed
the
bug/improve-contrast-link-in-markdown-note
branch
from
6588f9b to
cebb3b1
Compare
julien-nc
requested changes
Jan 18, 2022
src/components/card/Description.vue
Outdated
Comment on lines
336
to
351
| .vue-easymde .cm-s-easymde .cm-link, .cm-image-marker { | ||
| color: var(--color-text-maxcontrast); | ||
| } | ||
|
|
||
| .vue-easymde .cm-s-easymde .cm-image.cm-image-alt-text.cm-link{ | ||
| color: var(--color-main-text); | ||
| } | ||
|
|
||
| .vue-easymde .cm-s-easymde .cm-formatting.cm-formatting-image.cm-image.cm-image-alt-text.cm-link{ | ||
| color: var(--color-text-maxcontrast); | ||
| } | ||
|
|
||
| .vue-easymde .cm-s-easymde .cm-url { | ||
| color: #767676 !important; | ||
| } |
There was a problem hiding this comment.
The image link color was ok but the basic link color wasn't.
@luka-nextcloud Are you ok with those changes?
Suggested change
| .vue-easymde .cm-s-easymde .cm-link, .cm-image-marker { | |
| color: var(--color-text-maxcontrast); | |
| } | |
| .vue-easymde .cm-s-easymde .cm-image.cm-image-alt-text.cm-link{ | |
| color: var(--color-main-text); | |
| } | |
| .vue-easymde .cm-s-easymde .cm-formatting.cm-formatting-image.cm-image.cm-image-alt-text.cm-link{ | |
| color: var(--color-text-maxcontrast); | |
| } | |
| .vue-easymde .cm-s-easymde .cm-url { | |
| color: #767676 !important; | |
| } | |
| .vue-easymde .cm-s-easymde .cm-link { | |
| color: var(--color-main-text); | |
| } | |
| .vue-easymde .cm-s-easymde .cm-string.cm-url, | |
| .vue-easymde .cm-s-easymde .cm-formatting.cm-link, | |
| .vue-easymde .cm-s-easymde .cm-formatting.cm-url, | |
| .vue-easymde .cm-s-easymde .cm-formatting.cm-image { | |
| color: var(--color-text-maxcontrast); | |
| } |
There was a problem hiding this comment.
Ok, it looks better.
luka-nextcloud
force-pushed
the
bug/improve-contrast-link-in-markdown-note
branch
from
cebb3b1 to
0fa9c90
Compare
luka-nextcloud
force-pushed
the
bug/improve-contrast-link-in-markdown-note
branch
from
0fa9c90 to
5276bff
Compare
julien-nc
requested changes
Jan 20, 2022
src/components/card/Description.vue
Outdated
Comment on lines
348
to
351
|
|
||
| .vue-easymde .cm-s-easymde .cm-url { | ||
| color: #767676 !important; | ||
| } |
There was a problem hiding this comment.
Suggested change
| .vue-easymde .cm-s-easymde .cm-url { | |
| color: #767676 !important; | |
| } |
This is already done upper with .vue-easymde .cm-s-easymde .cm-string.cm-url,.
Signed-off-by: Luka Trovic <luka@nextcloud.com>
luka-nextcloud
force-pushed
the
bug/improve-contrast-link-in-markdown-note
branch
from
5276bff to
4e31332
Compare
julien-nc
approved these changes
Jan 21, 2022
delete-merged-branch
bot
deleted the
bug/improve-contrast-link-in-markdown-note
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luka Trovic luka@nextcloud.com
Summary
Improve contrast link in Markdown note
TODO
Checklist