Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CardApiController: Fix order of optional parameters #3512

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

simonspa
Copy link

@simonspa simonspa commented Jan 7, 2022

Signed-off-by: Simon Spannagel simonspa@kth.se

Summary

This fixes the logged error

{"reqId":"KPFJVKJ3cHDPY5qOA5Ec","level":3,"time":"2022-01-07T00:14:07+01:00","remoteAddr":"<ip>","user":"<user>","app":"PHP","method":"GET","url":"/index.php/apps/deck/api/v1.1/boards/13/stacks/58/cards/92?","message":"Required parameter $owner follows optional parameter $order at /var/www/nextcloud/apps/deck/lib/Controller/CardApiController.php#97","userAgent":"Mozilla/5.0 (Android) Nextcloud-android/3.18.1","version":"22.2.3.0","id":"61d8159819147"}

appearing when updating cards from the Deck Android app.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Simon Spannagel <simonspa@kth.se>
@juliushaertl juliushaertl merged commit 0ab5707 into nextcloud:master Jan 10, 2022
@juliushaertl
Copy link
Member

/backport to stable23

@juliushaertl
Copy link
Member

/backport to stable22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants