Fix CalDAV blocking and modernize circles API usage

[juliusknorr]

• Avoid blocking calendar access if something goes wrong while fetching deck entries
• Move any circles API usage to internal service and make use of new circles API to get the list of circles for a user

• Resolves: External CalDAV access no longer works after upgrade to 1.4.4 #3312

[juliusknorr]

@ArtificialOwl

deck/lib/Service/CirclesService.php

Line 56 in 81740c9

return \OCA\Circles\Api\v1\Circles::detailsCircle($circleId, true);

is still using the old API, would the following work fine for replacing that?

		// Enforce current user condition since we always want the full list of members
		/** @var CirclesManager $circlesManager */
		$circlesManager = \OC::$server->get(CirclesManager::class);
		$circlesManager->startSuperSession();
		return $circlesManager->getCircle($circleId);

[ArtificialOwl]

@ArtificialOwl

deck/lib/Service/CirclesService.php

Line 56 in 81740c9

return \OCA\Circles\Api\v1\Circles::detailsCircle($circleId, true);

is still using the old API, would the following work fine for replacing that?

		// Enforce current user condition since we always want the full list of members
		/** @var CirclesManager $circlesManager */
		$circlesManager = \OC::$server->get(CirclesManager::class);
		$circlesManager->startSuperSession();
		return $circlesManager->getCircle($circleId);

It should work, however you need to be sure that the params in getCircle(string $circleId) are not fed by a user:

deck/lib/Service/CirclesService.php

Line 51 in 81740c9

public function getCircle($circleId) {

[ArtificialOwl]

not tested, but code looks good.

The only comment I have is that after migration of CirclesService::getCircle() to the new API, the exception returned by the new API (if Circle is out of reach) will be managed by a catch (Throwable)

[juliusknorr]

/backport to stable23

[juliusknorr]

/backport to stable22