Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong SQL queries #2278

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Fix wrong SQL queries #2278

merged 1 commit into from
Sep 10, 2020

Conversation

Chartman123
Copy link
Contributor

@Chartman123 Chartman123 commented Sep 8, 2020

Add additional ', so that the resulting SQL query is correct

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@Chartman123
Copy link
Contributor Author

I've tested the fix on our Nextcloud and the error messages in the log files have gone.

@juliushaertl
Copy link
Member

Thanks a lot for the fix 👍

Mind to add a signoff message to your commit? :)

@Chartman123
Copy link
Contributor Author

Mind to add a signoff message to your commit? :)

Sorry... Is it possible to change the commit message or how can I add the signoff message?

@juliushaertl
Copy link
Member

You should be able to just signoff the last commit and do a force push with the following commands on your branch:

git commit --amend --signoff
git push -f

@Chartman123
Copy link
Contributor Author

You should be able to just signoff the last commit and do a force push with the following commands on your branch:

git commit --amend --signoff
git push -f

Ok, so I'll have to install git first... I edited the file and created the PR online directly in GitHub

Add additional ', so that the resulting SQL query is correct

Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123
Copy link
Contributor Author

Apparently it worked ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong SQL Selects resulting from new code
3 participants