Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unified search events to apply on board filtering #2255

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Use unified search events to apply on board filtering #2255

merged 1 commit into from
Oct 2, 2020

Conversation

juliushaertl
Copy link
Member

Requires nextcloud/server#22526 on the server

@juliushaertl juliushaertl added this to the ⭐ 1.1.0 milestone Sep 2, 2020
jakobroehrl
jakobroehrl approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@jakobroehrl jakobroehrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working, but I dont know how useful it is.
If the user does any click while showing the search results the search results are gone

@juliushaertl
Copy link
Member Author

juliushaertl commented Sep 3, 2020 •
edited
Loading

Yeah, we could just not reset the search query in deck when the unified search is closed but there would be no indicator or way to reset it then afterwards of course.

@skjnldsv Were there any discussions about that already UX wise? Issue in summary:

  • Unified search is opened, somthing is typed
  • The event is passed and the app filters the current view
  • The user clicks outside
  • The in app search gets reset

This was referenced Sep 16, 2020
Merged
Merged
@juliushaertl
Use unified search events to apply on board filtering
012e5b8 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl force-pushed the bugfix/noid/unified-search-filtering branch from 59b5f27 to 012e5b8 Compare October 2, 2020 11:22
@skjnldsv
Copy link
Member

skjnldsv commented Oct 2, 2020

@skjnldsv Were there any discussions about that already UX wise? Issue in summary:

  • Unified search is opened, somthing is typed
  • The event is passed and the app filters the current view
  • The user clicks outside
  • The in app search gets reset

sorry I missed this comment. Yeah, you fixed it with the reset/close event differences 🎉

@juliushaertl juliushaertl merged commit 4c2346c into master Oct 2, 2020
@juliushaertl juliushaertl deleted the bugfix/noid/unified-search-filtering branch October 2, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@jakobroehrl jakobroehrl jakobroehrl approved these changes

Assignees
No one assigned
Labels
4. to release bug
Projects
None yet
Milestone
⭐ 1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@juliushaertl @skjnldsv @jakobroehrl