Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scrolling per stack #2230

Merged
merged 7 commits into from
Nov 6, 2020
Merged

Implement scrolling per stack #2230

merged 7 commits into from
Nov 6, 2020

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Aug 24, 2020

Implements #2184

Peek 2020-10-13 11-36

  • Scroll each stack individually
  • Fade out cards at the top when scrolling
  • Scroll to card once inserted

@nextcloud/designers What do you think? Feels a bit more natural to use than always scrolling all lists

@stefan-niedermann
Copy link
Member

stefan-niedermann commented Aug 24, 2020

Really awesome it was if the scrollbar thumbs were a bit thiner and hidden until one hovers a column. Should be possible with pure CSS, at least in Chrome. (imho they have too much attention)

@juliushaertl
Copy link
Member Author

Really awesome it was if the scrollbar thumbs were a bit thiner and hidden until one hovers a column. Should be possible with pure CSS, at least in Chrome. (imho they have too much attention)

I also thought about that but was a bit concerned about the discoverability then.

@juliushaertl juliushaertl mentioned this pull request Sep 17, 2020
@juliushaertl
Copy link
Member Author

Let's move this to the next release

@juliushaertl juliushaertl modified the milestones: ⭐ 1.1.0, 1.1.1 Oct 2, 2020
@juliushaertl juliushaertl modified the milestones: 1.1.1, 1.1.2 Oct 13, 2020
@juliushaertl juliushaertl force-pushed the enh/scroll-stacks branch 2 times, most recently from 173c506 to 348057b Compare October 13, 2020 09:40
@juliushaertl juliushaertl marked this pull request as ready for review October 13, 2020 09:40
@juliushaertl juliushaertl modified the milestones: 1.1.2, 1.2.0 Oct 13, 2020
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, only some details – your call if to be fixed here or separately:

  • When you click the "Add" button, the entire stack moves a bit down cause of the new element. Would be nicer if it wouldn’t move
  • The autoscrolling to the inserted card could use a quick animation so people know what happened
  • Agree with @stefan-niedermann about the scrollbar, but we could also leave that for now for discoverability indeed.

@juliushaertl
Copy link
Member Author

When you click the "Add" button, the entire stack moves a bit down cause of the new element. Would be nicer if it wouldn’t move

But then we would overlay the existing cards, which I would prefer not to do.

The autoscrolling to the inserted card could use a quick animation so people know what happened

👍 Let me see if i can make that happen.

Agree with @stefan-niedermann about the scrollbar, but we could also leave that for now for discoverability indeed.

Then let's keep it for now. We can still experiment with hiding it in a follow up.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
This reverts commit abf6713.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
Copy link
Member Author

🏓 for reviews again :)

@@ -23,7 +23,7 @@

<template>
<div class="stack">
<div v-click-outside="stopCardCreation" class="stack--header">
<div v-click-outside="stopCardCreation" class="stack--header" :class="{'stack--header--add': showAddCard }">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a weird BEM syntax ^^

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed 🙈 adjusted with 78299b3

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl merged commit 297e060 into master Nov 6, 2020
@juliushaertl juliushaertl deleted the enh/scroll-stacks branch November 6, 2020 10:57
@der-flo
Copy link

der-flo commented Nov 23, 2020

This change makes it hard to scroll on iOS because every finger tip immediately starts dragging a card.

@der-flo
Copy link

der-flo commented Nov 27, 2020

This change makes it hard to scroll on iOS because every finger tip immediately starts dragging a card.

@juliushaertl Should I open a new issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make columns independently scrollable
5 participants