-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement scrolling per stack #2230
Conversation
Really awesome it was if the scrollbar thumbs were a bit thiner and hidden until one hovers a column. Should be possible with pure CSS, at least in Chrome. (imho they have too much attention) |
I also thought about that but was a bit concerned about the discoverability then. |
Let's move this to the next release |
173c506
to
348057b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, only some details – your call if to be fixed here or separately:
- When you click the "Add" button, the entire stack moves a bit down cause of the new element. Would be nicer if it wouldn’t move
- The autoscrolling to the inserted card could use a quick animation so people know what happened
- Agree with @stefan-niedermann about the scrollbar, but we could also leave that for now for discoverability indeed.
But then we would overlay the existing cards, which I would prefer not to do.
👍 Let me see if i can make that happen.
Then let's keep it for now. We can still experiment with hiding it in a follow up. |
ee592e1
to
69a3d4b
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
This reverts commit abf6713. Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
69a3d4b
to
4b8c811
Compare
🏓 for reviews again :) |
src/components/board/Stack.vue
Outdated
@@ -23,7 +23,7 @@ | |||
|
|||
<template> | |||
<div class="stack"> | |||
<div v-click-outside="stopCardCreation" class="stack--header"> | |||
<div v-click-outside="stopCardCreation" class="stack--header" :class="{'stack--header--add': showAddCard }"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a weird BEM syntax ^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed 🙈 adjusted with 78299b3
Signed-off-by: Julius Härtl <jus@bitgrid.net>
This change makes it hard to scroll on iOS because every finger tip immediately starts dragging a card. |
@juliushaertl Should I open a new issue? |
Implements #2184
@nextcloud/designers What do you think? Feels a bit more natural to use than always scrolling all lists