Cleanup unneeded cardId parameter #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
This is a new minor version of the REST API, isn't it? Minor because it is fully backward compatible, but it should be documented in the REST API documentation in this case. |
|
No, we don't change anything, just the parameter is not really needed so we don't need to pass it around. The URLs and behavior of the API stays the same. |
nickvergessen
approved these changes
Jul 11, 2020
juliushaertl
force-pushed
the
bugfix/noid/attachment-id-check
branch
from
2c9d2b9
to
062e4f7
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
bugfix/noid/attachment-id-check
branch
from
062e4f7
to
6114c28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.