Fix generated fronted urls

[juliushaertl]

Fix #1916
Fix #1922

[stefan-niedermann]

We have a share card url button in the android app. Are you aware of any change of the URL format across the different server versions?

[codecov-commenter]

Codecov Report

Merging #1925 into master will decrease coverage by 0.00%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master    #1925      +/-   ##
==========================================
- Coverage   56.92%   56.92%   -0.01%     
==========================================
  Files          77       77              
  Lines        3840     3842       +2     
==========================================
+ Hits         2186     2187       +1     
- Misses       1654     1655       +1     

[aszlig]

Doesn't this miss OCA\Deck\Activity\DeckProvider::deckUrl or are those bang-prefixed URL fragment identifiers still recognised?

[juliushaertl]

We have a share card url button in the android app. Are you aware of any change of the URL format across the different server versions?

Yeah, unfortunately there is not much we can do there since vue-router has removed the support for the hashbang prefixing. Maybe we should provide a server side unique link to cards that can then adapt to whatever the frontend is doing (similar to the files apps /f/{fileid}).

Doesn't this miss OCA\Deck\Activity\DeckProvider::deckUrl or are those bang-prefixed URL fragment identifiers still recognised?

Ah nope, good catch.

[stefan-niedermann]

Yeah, unfortunately there is not much we can do there since vue-router has removed the support for the hashbang prefixing.

Okay, so there actually is a change. Can you please tell me how the link looks across the different server app versions, for example:

0.0.1 - 0.8.1: example.com/apps/deck/#!/board/5/card3
0.8.1 - 1.0.0: example.com/apps/deck/app/#!/board/5/card3
     >= 1.0.1: example.com/apps/deck/board/5/card3

Then i am able take care that copying URLs will work with each server version.

Maybe we should provide a server side unique link to cards that can then adapt to whatever the frontend is doing (similar to the files apps /f/{fileid}).

This makes sense to prevent broken bookmark links. But you should ensure that this won't result in additional request with a redirect for the web UI users.

[juliushaertl]

See #1977 for the details and a fallback for the old routes.