add stack button on empty board #1865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1865 +/- ##
=======================================
Coverage 56.90% 56.90%
=======================================
Files 77 77
Lines 3840 3840
=======================================
Hits 2185 2185
Misses 1655 1655 |
|
I think we should have this in a emptycontent layout here similar to the board not found message. You can use our new component from |
jakobroehrl
force-pushed
the
enh/addStackOnEmptyBoard
branch
from
5e140b3
to
44d2dd1
Compare
jakobroehrl
force-pushed
the
enh/addStackOnEmptyBoard
branch
from
44d2dd1
to
05db9cc
Compare
src/components/board/Board.vue
Outdated
| @@ -23,6 +23,26 @@ | |||
| <template> | |||
| <div class="board-wrapper"> | |||
| <Controls :board="board" /> | |||
|
|
|||
| <EmptyContent v-if="stacksByBoard.length === 0" icon="icon-pause"> | |||
| No lists, add one | |||
There was a problem hiding this comment.
cc @jancborchardt for some nicer text maybe ;)
| @@ -117,11 +140,10 @@ export default { | |||
| this.$store.dispatch('orderStack', { stack: this.stacksByBoard[removedIndex], removedIndex, addedIndex }) | |||
| }, | |||
|
|
|||
| createStack() { | |||
| addNewStack() { | |||
There was a problem hiding this comment.
Make sure that newStackTitle is emptied once the stack has been created.
|
done, let's merge |
src/components/board/Board.vue
Outdated
| @@ -23,6 +23,26 @@ | |||
| <template> | |||
| <div class="board-wrapper"> | |||
| <Controls :board="board" /> | |||
|
|
|||
| <EmptyContent v-if="stacksByBoard.length === 0" icon="icon-pause"> | |||
| {{ t('deck', 'No lists, add one') }} | |||
There was a problem hiding this comment.
Let's do something more descriptive then here like:
No lists available
Create a new list to add cards to this board
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
enh/addStackOnEmptyBoard
branch
from
0b72dcd
to
ba0a482
Compare
juliushaertl
approved these changes
Jul 31, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jakob Röhrl jakob.roehrl@web.de
It shows only on empty board up:
