Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong rendering of nested checkbox lists #3637

Closed
a-mair opened this issue Mar 12, 2022 · 2 comments · Fixed by #3833
Closed

Wrong rendering of nested checkbox lists #3637

a-mair opened this issue Mar 12, 2022 · 2 comments · Fixed by #3833

Comments

@a-mair
Copy link

a-mair commented Mar 12, 2022

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Describe the bug
After updating to NextCloud 23 and Deck 1.6.0 nested checkbox lists no longer render correctly.

To Reproduce
Add a new card, set description to:

- [ ] a
	- [ ] a.a
- [ ] b
* x
	* x.x
* y

Expected behavior
This used to indent option "a.a", but now it's no longer indented. This makes it hard to distinguish both. It works for simple lists ("x.x").

Screenshots
Screenshot_20220312_094058

Client details:

  • OS: Gentoo Linux
  • Browser Firefox 97, Chrome 99
  • Device: desktop
Server details **Operating system**: Gentoo Linux

Web server: nginx

Database: mariadb

PHP version: 8.0

Nextcloud version: 23.0.2.1

@flummer
Copy link
Contributor

flummer commented May 22, 2022

Looks like this line is the culprit:

0fcbe2c#diff-df4c0a65a3465bff9b48533e35d4da7fd687e7875a61482850cdf7cd32f03a29R26

though having it seems correct, to move the checkbox left, and eliminate the extra margin.

Maybe adding this to the file (src/css/markdown.scss) will solve it:

li ul {
    margin-left: 40px;
}

flummer added a commit to flummer/nextcloud-deck that referenced this issue May 22, 2022
Added padding on nested ul, to compensate for the negative margin on the containing li

Signed-off-by: Thomas Flummer <tf@flummer.net>
@flummer flummer mentioned this issue May 22, 2022
4 tasks
@a-mair
Copy link
Author

a-mair commented Jun 5, 2022

You are right! That change fixes it. Thanks!

juliusknorr added a commit that referenced this issue Jul 5, 2022
backportbot-nextcloud bot pushed a commit that referenced this issue Jul 5, 2022
Added padding on nested ul, to compensate for the negative margin on the containing li

Signed-off-by: Thomas Flummer <tf@flummer.net>
juliusknorr added a commit that referenced this issue Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants