Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use all email addresses for gravatar search #2085

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Conversation

call-me-matt
Copy link
Member

fixes #2084

Signed-off-by: call-me-matt <nextcloud@matthiasheinisch.de>
@call-me-matt call-me-matt added the 3. to review Waiting for reviews label Feb 22, 2021
@call-me-matt call-me-matt self-assigned this Feb 22, 2021
@skjnldsv skjnldsv merged commit 1e281ed into master Feb 23, 2021
@skjnldsv skjnldsv deleted the fix/check-all-gravatars branch February 23, 2021 07:51
@Mannshoch
Copy link

I found this in the Changelog. Is it possible to deactivate Gravatar search? I do not wish to expose my address book to Gravatar.

@call-me-matt
Copy link
Member Author

No worries, this feature is deactivated by default. As admin, you can even disallow your users to make use of it (in the admin settings).
And by the way: even if you chose to fetch avatars from gravatar, you only transmit a hash of the email addresses.

@Mannshoch
Copy link

Ah, good, thank you for the hint.

Sorry but I do nod allow using Gravatar. Even it is only a Hash. Gravatar knows where this mail is used, so it has a network of website you visited and may could compare it with other.
If I understand it right, in the Contact app, you upload a hash of all contacts in several address book you have. In this case you allow Gravatar to track mail addresses that not itself opt-in getting tracked by Gravatar. If Gravatar in any case is able to detect the mail address behind the hash. e.g. by intelligent brute force >>{BRUTEFORCE}@{COMMON-MAIL-DOMAIN<< your whole Internet live is known by them.
I'm may be able to decide if I wish be tracked for my mail address (I don't wish) but I'm not able to do it for people in my address book.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gravatar profile is only taken from first mail entry
3 participants