Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new facebook api prevents usage without authentication #1894

Merged
merged 2 commits into from
Nov 7, 2020

Conversation

call-me-matt
Copy link
Member

well, not really a fix.
but due to lack of ideas I'd say we need to deactivate the facebook api for now
see #1891

Signed-off-by: call-me-matt <nextcloud@matthiasheinisch.de>
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #1894 (ff10197) into master (23e887b) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1894      +/-   ##
============================================
+ Coverage     67.43%   67.53%   +0.09%     
  Complexity      249      249              
============================================
  Files            22       22              
  Lines           691      690       -1     
============================================
  Hits            466      466              
+ Misses          225      224       -1     
Impacted Files Coverage Δ Complexity Δ
lib/Service/Social/CompositeSocialProvider.php 0.00% <ø> (ø) 6.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e887b...28355a2. Read the comment docs.

@skjnldsv skjnldsv added 3. to review Waiting for reviews bug Something isn't working labels Nov 7, 2020
@skjnldsv skjnldsv merged commit 80abee9 into master Nov 7, 2020
@skjnldsv skjnldsv deleted the fix/facebook-defunc branch November 7, 2020 16:26
@skjnldsv skjnldsv added this to the next milestone Nov 7, 2020
@skjnldsv skjnldsv removed this from the next milestone Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants