Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly sort groups #1788

Merged
merged 1 commit into from
Sep 6, 2020
Merged

Properly sort groups #1788

merged 1 commit into from
Sep 6, 2020

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 6, 2020

Fix #1598

Before After
dev skjnldsv com_apps_contacts_1contacts dev skjnldsv com_apps_contacts_ (1)

@skjnldsv
Properly sort groups
13abadd 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews design Related to the design papercut Annoying recurring issue with possibly simple fix. labels Sep 6, 2020
@skjnldsv skjnldsv self-assigned this Sep 6, 2020
@codecov
Copy link

codecov bot commented Sep 6, 2020

Codecov Report

Merging #1788 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1788   +/-   ##
=========================================
  Coverage     34.38%   34.38%           
  Complexity      148      148           
=========================================
  Files            19       19           
  Lines           442      442           
=========================================
  Hits            152      152           
  Misses          290      290

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c00530f...13abadd. Read the comment docs.

@call-me-matt
Copy link
Member

While checking, I stumbled upon this:
Is that a known issue or a bug with my deployment?
grafik

@skjnldsv skjnldsv merged commit 6144342 into master Sep 6, 2020
@skjnldsv skjnldsv deleted the fix/groups-sort branch September 6, 2020 14:16
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 6, 2020

While checking, I stumbled upon this:
Is that a known issue or a bug with my deployment?
grafik

Yes :)
Fixed in vue components

@skjnldsv skjnldsv added this to the 3.4.0 milestone Oct 1, 2020
This was referenced Feb 17, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@call-me-matt call-me-matt call-me-matt approved these changes

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working design Related to the design papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Enhancement for alphabetic sorting of groups if there are numbers
2 participants
@skjnldsv @call-me-matt