Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support X-PHONETIC-FIRST-NAME and X-PHONETIC-LAST-NAME #1741

Merged
merged 4 commits into from
Aug 13, 2020

Conversation

t-bucchi
Copy link
Contributor

@t-bucchi t-bucchi commented Aug 9, 2020

fix #251
I wrote the patch to support X-PHONETIC-FIRST-NAME and X-PHONETIC-LAST-NAME properties (issue #251) based on v3.3.0.
This patch changes two things:

  • Add "Phonetic first name" and "Phonetic last name" to detail view.
  • Add "Phonetic first name" and "Phonetic last name" to sort keys.

In Japan, a phonetic (pronounce) name is one of the essential feature for address book.
Because, the Kanji character has many pronunciation.
So, usually contact list is sorted by phonetic order.

NOTE: The X-PHONETIC-FIRST-NAME and X-PHONETIC-LAST-NAME properties are
already normally supported on Android and iOS.

Could you review and merge my code?

Thanks!

@codecov
Copy link

codecov bot commented Aug 9, 2020

Codecov Report

Merging #1741 into master will decrease coverage by 35.38%.
The diff coverage is 35.10%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #1741       +/-   ##
=============================================
- Coverage     75.43%   40.05%   -35.39%     
- Complexity       13      128      +115     
=============================================
  Files             4       17       +13     
  Lines            57      377      +320     
=============================================
+ Hits             43      151      +108     
- Misses           14      226      +212     
Impacted Files Coverage Δ Complexity Δ
appinfo/app.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
appinfo/routes.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
lib/AppInfo/Application.php 0.00% <0.00%> (ø) 1.00 <1.00> (?)
lib/Controller/SocialApiController.php 0.00% <0.00%> (ø) 9.00 <9.00> (?)
lib/Cron/SocialUpdate.php 0.00% <0.00%> (ø) 2.00 <2.00> (?)
lib/Cron/SocialUpdateRegistration.php 0.00% <0.00%> (ø) 4.00 <4.00> (?)
lib/Service/Social/CompositeSocialProvider.php 0.00% <0.00%> (ø) 10.00 <10.00> (?)
lib/Service/Social/FacebookProvider.php 0.00% <0.00%> (ø) 10.00 <10.00> (?)
lib/Service/Social/InstagramProvider.php 0.00% <0.00%> (ø) 9.00 <9.00> (?)
lib/Service/Social/MastodonProvider.php 0.00% <0.00%> (ø) 9.00 <9.00> (?)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 872e74b...b3eec9e. Read the comment docs.

Signed-off-by: Tomohiro Masubuchi <bucchi79@gmail.com>
Signed-off-by: Tomohiro Masubuchi <bucchi79@gmail.com>
@skjnldsv skjnldsv added 3. to review Waiting for reviews discussion Being discussed labels Aug 10, 2020
src/models/contact.js Outdated Show resolved Hide resolved
css/Properties/Properties.scss Outdated Show resolved Hide resolved
This changes was pointed out int the review at https://github.com/nextcloud/contacts/pull/1741/files/59f23ed514cf7c653b779af8dc65e26ec221184e#r468369340

Signed-off-by: Tomohiro Masubuchi <bucchi79@gmail.com>
Signed-off-by: Tomohiro Masubuchi <bucchi79@gmail.com>
@t-bucchi t-bucchi requested a review from skjnldsv August 12, 2020 12:57
@skjnldsv skjnldsv merged commit 2b4c5d7 into nextcloud:master Aug 13, 2020
@welcome
Copy link

welcome bot commented Aug 13, 2020

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-contacts and #nextcloud-dev on Freenode for a chat!

@skjnldsv
Copy link
Member

Congrats!!
Thanks a lot for your awesome work! :)

@t-bucchi
Copy link
Contributor Author

Thank you for your helping!
I'm glad to contribute!

@t-bucchi t-bucchi deleted the feature/phonetic-3.3.0 branch August 15, 2020 06:49
@skjnldsv skjnldsv added this to the 3.4.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews discussion Being discussed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phonetic name support
2 participants