allow for regular background updates of avatars from social networks #1722

call-me-matt · 2020-07-31T12:22:55Z

implements #1594

codecov · 2020-07-31T13:25:06Z

Codecov Report

Merging #1722 into master will decrease coverage by 4.58%.
The diff coverage is 24.07%.

@@             Coverage Diff              @@
##             master    #1722      +/-   ##
============================================
- Coverage     35.35%   30.76%   -4.59%     
- Complexity      101      128      +27     
============================================
  Files            15       17       +2     
  Lines           280      377      +97     
============================================
+ Hits             99      116      +17     
- Misses          181      261      +80

Impacted Files	Coverage Δ	Complexity Δ
appinfo/routes.php	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
lib/Controller/SocialApiController.php	`0.00% <0.00%> (ø)`	`9.00 <4.00> (+4.00)`
lib/Cron/SocialUpdate.php	`0.00% <0.00%> (ø)`	`2.00 <2.00> (?)`
lib/Cron/SocialUpdateRegistration.php	`0.00% <0.00%> (ø)`	`4.00 <4.00> (?)`
lib/Settings/AdminSettings.php	`0.00% <ø> (ø)`	`5.00 <0.00> (ø)`
lib/Service/SocialApiService.php	`51.57% <13.63%> (-33.33%)`	`36.00 <16.00> (+16.00)`	⬇️
lib/Controller/PageController.php	`100.00% <100.00%> (ø)`	`3.00 <0.00> (+1.00)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b78f4d6...973c288. Read the comment docs.

README.md

lib/Controller/PageController.php

lib/Cron/SocialUpdateRegistration.php

src/components/AdminSettings.vue

lib/Service/SocialApiService.php

call-me-matt · 2020-07-31T18:57:02Z

lib/Service/SocialApiService.php

+	 */
+	protected function registerAddressbooks($user, IManager $manager) {
+		$cm = new ContactsManager($this->davBackend, $this->l10n);
+		$cm->setupContactsProvider($manager, $user, $this->urlGen);


Is there a way to limit this to active address books owned by a user? i. e. return address books which are

not system address book

not shared address book from other user

not deactivated

Maybe we can enhance the IManager or IAddressBook?

cc @georgehrke what do you think? Does it make sense to add filters to the IAddressBook interface?

call-me-matt · 2020-07-31T19:06:55Z

lib/Service/SocialApiService.php

+
+			// get contacts in that addressbook
+			$contacts = $addressBook->search('', ['UID'], ['types' => true]);
+			// TODO: filter for contacts with social profiles


Could be optimized with $addressBook->search('', ['X-SOCIALPROFILE'], ['types' => true]);, if X-SOCIALPROFILE was indexed

Could be optimized with $addressBook->search('', ['X-SOCIALPROFILE'], ['types' => true]);, if X-SOCIALPROFILE was indexed

Mind to add this? :)

if it's not indexed (for older version) does it still works? Is the searched value just ignored?
If so it's ok I guess :)

Right, I have included this and added a fallback for older server versions.
~~But concerning the indexer, I could not find out how to add the X-SOCIALPROFILE. Simply adding it to the linked array did not have any effect.~~ Edit: worked after running cron to update the index.

Pull request created: nextcloud/server#22085

Turns out it was not cron, but me refreshing the profiles and triggering a re-index by that - it only works for new or modified contacts! We'll need a background job to re-index all contacts when a user activates this function. @skjnldsv or is there a better way / place to do that? We could, of course, also just ignore this and activate the optimization in a later release - hoping that contacts have been refreshed between the extension of the indexed fields and the moment we start to filter for that.

lib/Service/SocialApiService.php

lib/Controller/SocialApiController.php

required in order to optimize regular background updates of contact avatars from social networks (see nextcloud/contacts#1722 (comment))

Signed-off-by: call-me-matt <nextcloud@matthiasheinisch.de>

MorrisJobke · 2020-09-15T10:36:35Z

😢

call-me-matt · 2020-09-17T21:26:10Z

Ups, I'm sorry. That was an accident.

…ddressBook This allows to just UPDATE the card row instead of deleting it and reinsert it. It's very similar to #30120 for calendars. As we need the addressbookid exposed, this introduces OCA\DAV\CardDAV\Card that extends Sabre's. I chose specifically NOT to auto-inject LoggerInterface in Addressbook like in #30120 because the chain of DI is huge just for ONE simple call and it would break an existing dirty call (OCA\Contacts calling OCA\DAV) of ContactsManager in Contacts: nextcloud/contacts#1722 (in SocialApiService), but this is debatable. Signed-off-by: Thomas Citharel <tcit@tcit.fr>

call-me-matt self-assigned this Jul 31, 2020

call-me-matt force-pushed the enh/social-updater branch 2 times, most recently from 8cf1b21 to 64187bd Compare July 31, 2020 13:23

skjnldsv reviewed Jul 31, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

skjnldsv reviewed Jul 31, 2020

View reviewed changes

lib/Controller/PageController.php Outdated Show resolved Hide resolved

skjnldsv reviewed Jul 31, 2020

View reviewed changes

lib/Cron/SocialUpdateRegistration.php Outdated Show resolved Hide resolved

skjnldsv reviewed Jul 31, 2020

View reviewed changes

lib/Cron/SocialUpdateRegistration.php Outdated Show resolved Hide resolved

skjnldsv reviewed Jul 31, 2020

View reviewed changes

src/components/AdminSettings.vue Show resolved Hide resolved

skjnldsv reviewed Jul 31, 2020

View reviewed changes

lib/Service/SocialApiService.php Outdated Show resolved Hide resolved

call-me-matt commented Jul 31, 2020

View reviewed changes

lib/Service/SocialApiService.php Outdated Show resolved Hide resolved

call-me-matt commented Jul 31, 2020

View reviewed changes

lib/Service/SocialApiService.php Outdated Show resolved Hide resolved

call-me-matt force-pushed the enh/social-updater branch from d64317c to efd993d Compare July 31, 2020 19:53

skjnldsv reviewed Jul 31, 2020

View reviewed changes

lib/Controller/SocialApiController.php Outdated Show resolved Hide resolved

call-me-matt force-pushed the enh/social-updater branch 2 times, most recently from df55f34 to 73691e4 Compare July 31, 2020 23:07

skjnldsv added 2. developing Work in progress enhancement New feature or request labels Aug 1, 2020

call-me-matt force-pushed the enh/social-updater branch from d6555f3 to fdacb31 Compare August 2, 2020 05:32

call-me-matt linked an issue Aug 2, 2020 that may be closed by this pull request

Design improvements on "Update avatar from social media" feature #1594

Closed

call-me-matt force-pushed the enh/social-updater branch from 36b5abf to c87cfbc Compare August 2, 2020 11:57

call-me-matt added a commit to nextcloud/server that referenced this pull request Aug 2, 2020

adding social profile to search index

4679e85

required in order to optimize regular background updates of contact avatars from social networks (see nextcloud/contacts#1722 (comment))

call-me-matt mentioned this pull request Aug 2, 2020

adding social profile to search index nextcloud/server#22085

Merged

call-me-matt force-pushed the enh/social-updater branch 5 times, most recently from f75d37b to 4f3a2a3 Compare August 4, 2020 21:46

call-me-matt force-pushed the enh/social-updater branch 3 times, most recently from 4c32f71 to e0bf1fc Compare August 4, 2020 22:19

allowing for background updates of social avatars

973c288

Signed-off-by: call-me-matt <nextcloud@matthiasheinisch.de>

call-me-matt force-pushed the enh/social-updater branch from e0bf1fc to 973c288 Compare August 4, 2020 22:23

call-me-matt marked this pull request as ready for review August 4, 2020 22:39

skjnldsv approved these changes Aug 10, 2020

View reviewed changes

skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 10, 2020

call-me-matt merged commit 752bb14 into nextcloud:master Aug 11, 2020

MorrisJobke mentioned this pull request Sep 15, 2020

Fix transifex config #1801

Merged

skjnldsv added this to the 3.4.0 milestone Oct 1, 2020

tcitworld mentioned this pull request Mar 21, 2023

feat(CardDAV): Add Sabre\DAV\IMoveTarget support to OCA\DAV\CardDAV\AddressBook nextcloud/server#37326

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

allow for regular background updates of avatars from social networks #1722

allow for regular background updates of avatars from social networks #1722

call-me-matt commented Jul 31, 2020

codecov bot commented Jul 31, 2020 •

edited

Loading

call-me-matt Jul 31, 2020 •

edited

Loading

skjnldsv Jul 31, 2020

call-me-matt Jul 31, 2020

skjnldsv Aug 2, 2020

skjnldsv Aug 2, 2020

call-me-matt Aug 2, 2020 •

edited

Loading

call-me-matt Aug 2, 2020

call-me-matt Aug 3, 2020 •

edited

Loading

MorrisJobke commented Sep 15, 2020

call-me-matt commented Sep 17, 2020

allow for regular background updates of avatars from social networks #1722

allow for regular background updates of avatars from social networks #1722

Conversation

call-me-matt commented Jul 31, 2020

codecov bot commented Jul 31, 2020 • edited Loading

Codecov Report

call-me-matt Jul 31, 2020 • edited Loading

Choose a reason for hiding this comment

skjnldsv Jul 31, 2020

Choose a reason for hiding this comment

call-me-matt Jul 31, 2020

Choose a reason for hiding this comment

skjnldsv Aug 2, 2020

Choose a reason for hiding this comment

skjnldsv Aug 2, 2020

Choose a reason for hiding this comment

call-me-matt Aug 2, 2020 • edited Loading

Choose a reason for hiding this comment

call-me-matt Aug 2, 2020

Choose a reason for hiding this comment

call-me-matt Aug 3, 2020 • edited Loading

Choose a reason for hiding this comment

MorrisJobke commented Sep 15, 2020

call-me-matt commented Sep 17, 2020

codecov bot commented Jul 31, 2020 •

edited

Loading

call-me-matt Jul 31, 2020 •

edited

Loading

call-me-matt Aug 2, 2020 •

edited

Loading

call-me-matt Aug 3, 2020 •

edited

Loading