Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove delete buttons and other actions if contact is not readable #1413

Merged

Conversation

myrho
Copy link
Contributor

@myrho myrho commented Jan 16, 2020

Removes delete buttons, datepicker and other actions on properties if the contact is not readable

@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #1413 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1413   +/-   ##
=======================================
  Coverage   62.31%   62.31%           
=======================================
  Files           4        4           
  Lines          69       69           
=======================================
  Hits           43       43           
  Misses         26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 908607a...63c8028. Read the comment docs.

@skjnldsv skjnldsv added 3. to review Waiting for reviews bug Something isn't working labels Jan 16, 2020
@skjnldsv skjnldsv merged commit 7229c24 into nextcloud:master Jan 16, 2020
@welcome
Copy link

welcome bot commented Jan 16, 2020

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-contacts and #nextcloud-dev on Freenode for a chat!

@skjnldsv skjnldsv added this to the next milestone Jan 18, 2020
@skjnldsv skjnldsv modified the milestones: next, 3.1.7-3.1.9 Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants