Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw z-app-generated--contactsinteraction--recent URI visible to user #2187

Closed
Tracked by #19575
ChristophWurst opened this issue May 3, 2021 · 18 comments · Fixed by #3339
Closed
Tracked by #19575

Raw z-app-generated--contactsinteraction--recent URI visible to user #2187

ChristophWurst opened this issue May 3, 2021 · 18 comments · Fixed by #3339
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working

Comments

@ChristophWurst
Copy link
Member

Describe the bug

Recent contacts show the address but URI instead of the display name.

To Reproduce
Steps to reproduce the behavior:

  1. Have recent_contacts enabled
  2. Contact someone
  3. Open the contacts app
  4. Open the entry of this contact
  5. See

Expected behavior

The contact in an address book "Recently contacted".

Actual behavior

Bildschirmfoto von 2021-05-03 19-07-57

Server configuration

The Nextcloud.

@ChristophWurst ChristophWurst added bug Something isn't working 0. to triage Pending approval or rejection. This issue is pending approval. labels May 3, 2021
@skjnldsv
Copy link
Member

skjnldsv commented May 3, 2021

You can have a displayname on addressbooks backend :)

@ChristophWurst
Copy link
Member Author

That is done in \OCA\ContactsInteraction\AddressBook::getProperties. Is the {DAV:}displayname not picked up?

@skjnldsv
Copy link
Member

skjnldsv commented May 3, 2021

I'll investigate 🔎

@ChristophWurst
Copy link
Member Author

That address book is virtual and read-only. Write access is not intended. The app responsible for this lives at https://github.com/nextcloud/server/tree/master/apps/contactsinteraction if you want to have a look yourself.

@dcrobertson01
Copy link

How do I disable this address book? I now have a contacts list full of people I have no idea who they are or how they got put into my address book, and who I cannot delete, and who are in an addressbook I cannot delete or hide.

@dcrobertson01
Copy link

I am guessing they are the parents of my son's classmates, and they are in my addressbook now because his teacher does not know how to use BCC.

@ChristophWurst
Copy link
Member Author

Disable the contactsinteraction app.

@misterfitz
Copy link

I had a similar issue where a close but incorrectly entered email contact was found, I think from an old calendar invite.

Disabling and re-enabling the contactinteraction app worked as @ChristophWurst suggested here #2187 (comment), thanks!

I suspect the wrong contact came from me initially typing the wrong email into an invite some time ago. It was rather persistent and seemed to always come up as the first suggestion. Very difficult to get rid of. A feature to block/ban suggested contact might be helpful here?

@conspacer
Copy link

Disabling the contactinteraction does remove those phantom cards, but enabling it again just brings them back. Would I need to clear some data from the app directory or DB?

@tkurbad
Copy link

tkurbad commented Jan 14, 2022

Disabling the contactinteraction does remove those phantom cards, but enabling it again just brings them back. Would I need to clear some data from the app directory or DB?

Im also interested to know!

@iluvatyr
Copy link

I would also like to know.

@ChristophWurst
Copy link
Member Author

clearing of those entries is currently not supported. you can try deleting the database entries but if this breaks something you will be on your own.

@Holmsey123
Copy link

Has there been any improvement? I've also got the issue at the moment where I can't delete some of the contacts. It happened once I added a google calendar ics file to nextcloud - maybe that brought across something?

@new-on-github
Copy link

Has there been any improvement? I've also got the issue at the moment where I can't delete some of the contacts. It happened once I added a google calendar ics file to nextcloud - maybe that brought across something?

I would also be happy to see a solution. But in a other issue, some told it will not be fixed:
nextcloud/server#27524 (comment)

But I don't unterstand it. Why should the recently-contacted-adressbook be read-only? If you once send a mail to mail-address which you wrongly typed in, then it will be always in auto-completion. This seems to me really annoying. But maybe i don't get the point and there is a good reason for this.

@mokahless
Copy link

Why do these exist in the first place? Google brought me here because one of my contacts was mysteriously duplicated, apparently because I sent them a calendar invite to something? Why would that be?

The new duplicate is read-only and under the group "Recently contacted" with a new Address book entry of "z-app-generated--contactsinteraction--recent"

As a simple end-user, all I know is my contacts are duplicated if I send a calendar invite to anyone already in my contacts and the duplicates are read only so can't be deleted. This means calendar invites are unusable. I tried removing the attendee from the calendar but the undeletable duplicate contact remained.

The solution is "disable contactsinteraction app?" What is that? Where is it? Why isn't it disabled by default if this behaviour seems to be causing stupid end-users like me to have strange issues with duplicating contacts? What even is "recently-contacted-addressbook?"

@tgitnh
Copy link

tgitnh commented Apr 13, 2023

The "recently contacted" address book is a good idea, but I disabled the "Contacts interaction" app for the time being.

I'm having exactly the same problems discussed here: some incorrectly typed mail addresses, contacts from calendar invites which I don't want or need, etc. And all of these appear in auto-completion whenever you want to write a mail.

Please add the possibility to delete contacts from the address book and/or add user settings/options for this app to customize/disable some of its features.

@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of and removed 0. to triage Pending approval or rejection. This issue is pending approval. labels Apr 25, 2023
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 1. to develop Accepted and waiting to be taken care of labels Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

13 participants