Add ability to clone contact

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

.travis.yml

@@ -38,7 +38,7 @@ matrix:
     - php: 7.2
       env: "DB=mysql CORE_BRANCH=master"
     - php: 7.3
-      env: "DB=mysql CORE_BRANCH=master TEST_JS=TRUE PHP_COVERAGE=TRUE"
+      env: "DB=mysql CORE_BRANCH=master PHP_COVERAGE=TRUE"
     - php: 7.2
       env: "DB=pgsql CORE_BRANCH=master"
     - php: 7.3
@@ -96,14 +96,6 @@ script:
   # Run server's app code checker
   - php ../../occ app:check-code contacts
 
-  # Run JS tests
-  - if [[ "$TEST_JS" = "TRUE" ]];
-    then make test;
-    fi
-
-  # Test JS compilation
-  - make build-js-production
-
   # Test php
   - make test-php
   - if [[ "$PHP_COVERAGE" = "TRUE" ]];

css/icons.scss

@@ -29,6 +29,7 @@
 @include icon-black-white('up', 'contacts', 1);
 @include icon-black-white('no-calendar', 'contacts', 1);
 @include icon-black-white('language', 'contacts', 2);
+@include icon-black-white('clone', 'contacts', 2);
 
 .icon-up-force-white {
 	// using #fffffe to trick the accessibility dark theme icon invert
@@ -54,3 +55,4 @@
 	// using #fffffe to trick the accessibility dark theme icon invert
 	@include icon-color('picture', 'places', '#fffffe', 1, true);
 }
+

src/components/ContactDetails.vue

@@ -94,7 +94,7 @@
 						:class="{'icon-loading-small': loadingUpdate,
 							[`${warning.icon}`]: warning}"
 						class="header-icon"
-						href="#" />
+						@click="onWarningClick" />
 
 					<!-- conflict message -->
 					<div v-if="conflict"
@@ -117,12 +117,22 @@
 						@click="updateContact" />
 
 					<!-- menu actions -->
-					<Actions class="header-menu" menu-align="right">
+					<Actions ref="actions"
+						class="header-menu"
+						menu-align="right"
+						:open.sync="openedMenu">
 						<ActionLink :href="contact.url"
 							:download="`${contact.displayName}.vcf`"
 							icon="icon-download">
 							{{ t('contacts', 'Download') }}
 						</ActionLink>
+						<!-- user can clone if there is at least one option available -->
+						<ActionButton v-if="isReadOnly && addressbooksOptions.length > 0"
+							ref="cloneAction"
+							icon="icon-clone"
+							@click="cloneContact">
+							{{ t('contacts', 'Clone contact') }}
+						</ActionButton>
 						<ActionButton icon="icon-qrcode" @click="showQRcode">
 							{{ t('contacts', 'Generate QR Code') }}
 						</ActionButton>
@@ -377,6 +387,7 @@ export default {
 
 		/**
 		 * Store getters filtered and mapped to usable object
+		 * This is the list of addressbooks that are available to write
 		 *
 		 * @returns {Array}
 		 */
@@ -550,6 +561,38 @@ export default {
 			}
 		},
 
+		/**
+		 * Copy contact to the specified addressbook
+		 *
+		 * @param {string} addressbookId the desired addressbook ID
+		 */
+		async copyContactToAddressbook(addressbookId) {
+			const addressbook = this.addressbooks.find(search => search.id === addressbookId)
+			this.loadingUpdate = true
+			if (addressbook) {
+				try {
+					const contact = await this.$store.dispatch('copyContactToAddressbook', {
+						// we need to use the store contact, not the local contact
+						// using this.contact and not this.localContact
+						contact: this.contact,
+						addressbook,
+					})
+					// select the contact again
+					this.$router.push({
+						name: 'contact',
+						params: {
+							selectedGroup: this.$route.params.selectedGroup,
+							selectedContact: contact.key,
+						},
+					})
+				} catch (error) {
+					console.error(error)
+				} finally {
+					this.loadingUpdate = false
+				}
+			}
+		},
+
 		/**
 		 * Refresh the data of a contact
 		 */
@@ -589,6 +632,30 @@ export default {
 				this.debounceUpdateContact()
 			}
 		},
+
+		/**
+		 * Clone the current contact to another addressbook
+		 */
+		cloneContact() {
+			// only one addressbook, let's clone it there
+			if (this.addressbooksOptions.length === 1) {
+				this.copyContactToAddressbook(this.addressbooksOptions[0].id)
+			}
+		},
+
+		/**
+		 * The user clicked the warning icon
+		 */
+		onWarningClick() {
+			// if the user clicked the readonly icon, let's focus the clone button
+			if (this.isReadOnly && this.addressbooksOptions.length > 0) {
+				this.openedMenu = true
+				this.$nextTick(() => {
+					// focus the clone button
+					this.$refs.actions.onMouseFocusAction({ target: this.$refs.cloneAction.$el })
+				})
+			}
+		},
 	},
 }
 </script>

src/components/Properties/PropertyMultipleText.vue

@@ -63,8 +63,8 @@
 				@input="updateValue">
 
 			<!-- props actions -->
-			<PropertyActions class="property__actions--floating"
-				v-if="!isReadOnly"
+			<PropertyActions v-if="!isReadOnly"
+				class="property__actions--floating"
 				:actions="actions"
 				:property-component="this"
 				@delete="deleteProperty" />

src/store/addressbooks.js

@@ -407,7 +407,7 @@ const actions = {
 
 			// Get vcard string
 			try {
-				const vData = ICAL.stringify(contact.vCard.jCal)
+				const vData = contact.vCard.toString()
 				// push contact to server and use limit
 				requests.push(limit(() => contact.addressbook.dav.createVCard(vData)
 					.then((response) => {
@@ -512,6 +512,34 @@ const actions = {
 		await context.commit('addContactToAddressbook', contact)
 		return contact
 	},
+
+	/**
+	 * Copy a contact to the provided addressbook
+	 *
+	 * @param {Object} context the store mutations
+	 * @param {Object} data destructuring object
+	 * @param {Contact} data.contact the contact to copy
+	 * @param {Object} data.addressbook the addressbook to move the contact to
+	 * @returns {Contact} the new contact object
+	 */
+	async copyContactToAddressbook(context, { contact, addressbook }) {
+		// init new contact & strip old uid
+		const vData = contact.vCard.toString().replace(/^UID.+/im, '')
+		const newContact = new Contact(vData, addressbook)
+
+		try {
+			const response = await contact.dav.copy(addressbook.dav)
+			// setting the contact dav property
+			Vue.set(newContact, 'dav', response)
+
+		} catch (error) {
+			throw error
+		}
+		// success, update store
+		await context.commit('addContact', newContact)
+		await context.commit('addContactToAddressbook', newContact)
+		return newContact
+	},
 }
 
 export default { state, mutations, getters, actions }