Build parent path without queries #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
enh/performance
branch
from
e534c1d to
b9946fb
Compare
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
juliusknorr
force-pushed
the
enh/performance
branch
from
b9946fb to
e0567bb
Compare
juliusknorr
force-pushed
the
enh/performance
branch
from
e0567bb to
dc79d8a
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
enh/performance
branch
from
dc79d8a to
7ae853d
Compare
|
@mejo- Tests pass now and this would be ready for review. I just can't request your review due to the migration from gitlab ;) |
juliusknorr
changed the title
mejo-
commented
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GitLab by @juliushaertl on Aug 18, 2022, 13:28
Cuts down the queries in half on our perftesting instance for the handbook example collective: 948 -> 541
Related upstream fix in server, but is not fully applicable here due to the recursive directory iteration nextcloud/server#33602
Fixes #377