Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertically center text inside callouts #1175

Closed
viktorix opened this issue Mar 25, 2024 · 0 comments · Fixed by nextcloud/text#5310
Closed

Vertically center text inside callouts #1175

viktorix opened this issue Mar 25, 2024 · 0 comments · Fixed by nextcloud/text#5310
Assignees
@mejo-
Labels
enhancement New feature or request

Comments

@viktorix
Copy link

viktorix commented Mar 25, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
The text inside a callout isn't vertically centered, which is more visible with shorter text and larger bottom space. Maybe it's just my OCD, but it keeps bothering me. Visually, it looks like a bug since it isn't centered. This seems to be due to the bottom margin set on all .paragraph-content elements inside the callout.

Describe the solution you'd like
This is a small CSS change to set the bottom margin of the last element to zero using last-child pseudo-class, so the text appears to be centered again.
OnPaste 20240325-090859

Thank you.
@viktorix viktorix added the enhancement New feature or request label Mar 25, 2024
mejo- pushed a commit to nextcloud/text that referenced this issue Mar 25, 2024
@Jerome-Herbinet @mejo-
Remove bottom margin for better warning blocks display
dd1e1d4 
Fixes: nextcloud/collectives#1175

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jonas <jonas@freesources.org>
mejo- pushed a commit to nextcloud/text that referenced this issue Mar 25, 2024
@Jerome-Herbinet @mejo-
Remove bottom margin for better warning blocks display
9ca90fc 
Fixes: nextcloud/collectives#1175

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- mentioned this issue Mar 25, 2024
Merged
2 tasks
@mejo- mejo- self-assigned this Mar 25, 2024
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Mar 25, 2024
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 📝 Office team Mar 25, 2024
@mejo- mejo- moved this from 🏗️ In progress to 👀 In review in 📝 Office team Mar 25, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ☑️ Done in 📝 Office team Mar 25, 2024
backportbot bot pushed a commit to nextcloud/text that referenced this issue Mar 25, 2024
@Jerome-Herbinet @backportbot
Remove bottom margin for better warning blocks display
64a3d01 
Fixes: nextcloud/collectives#1175

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jonas <jonas@freesources.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mejo- mejo-

Labels
enhancement New feature or request
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove bottom margin for better warning blocks display nextcloud/text
2 participants
@viktorix @mejo-