Skip to content

Commit

Permalink
Merge pull request #176 from nextcloud/bugfix/sparkle-2-support
Browse files Browse the repository at this point in the history 
Add Sparkle 2 required sparkle:installationType to response Sparkle enclosure
  • Loading branch information
@mgallien
mgallien authored Feb 11, 2025
2 parents a1c088c + 38a9a8d commit 092be1c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/Response.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ private function buildSparkleResponse(array $updateVersion) : string {
<item>
<title>'.$versionString.'</title>
<pubDate>'.$this->getCurrentTimeStamp().'</pubDate>
<enclosure url="'.$sparkleUrl.'" sparkle:version="'.$updateVersion['version'].'" type="application/octet-stream" sparkle:edSignature="'.$sparkleSignature.'" length="'.$sparkleLength.'"/>
<enclosure url="'.$sparkleUrl.'" sparkle:version="'.$updateVersion['version'].'" type="application/octet-stream" sparkle:installationType="package" sparkle:edSignature="'.$sparkleSignature.'" length="'.$sparkleLength.'"/>
<sparkle:minimumSystemVersion>11.0</sparkle:minimumSystemVersion>
</item>' : '';

Expand Down
14 changes: 7 additions & 7 deletions tests/unit/ResponseTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ public function updateDataProvider(): array
<item>
<title>Nextcloud Client 2.2.2 (build 3472)</title>
<pubDate>Wed, 13 July 16 21:07:31 +0200</pubDate>
<enclosure url="https://download.owncloud.com/desktop/stable/ownCloud-2.2.2.3472.pkg.tbz" sparkle:version="2.2.2.3472" type="application/octet-stream" sparkle:edSignature="MC0CFQDmXR6biDmNVW7TvMh0bfPPTzCvtwIUCzASgpzYdi4lltOnwbFCeQwgDjY=" length="62738920"/>
<enclosure url="https://download.owncloud.com/desktop/stable/ownCloud-2.2.2.3472.pkg.tbz" sparkle:version="2.2.2.3472" type="application/octet-stream" sparkle:installationType="package" sparkle:edSignature="MC0CFQDmXR6biDmNVW7TvMh0bfPPTzCvtwIUCzASgpzYdi4lltOnwbFCeQwgDjY=" length="62738920"/>
<sparkle:minimumSystemVersion>11.0</sparkle:minimumSystemVersion>
</item>
</channel>
Expand Down Expand Up @@ -402,7 +402,7 @@ public function updateDataProvider(): array
<item>
<title>Nextcloud Client 2.2.2 (build 3472)</title>
<pubDate>Wed, 13 July 16 21:07:31 +0200</pubDate>
<enclosure url="https://download.owncloud.com/desktop/stable/ownCloud-2.2.2.3472.pkg.tbz" sparkle:version="2.2.2.3472" type="application/octet-stream" sparkle:edSignature="MC0CFQDmXR6biDmNVW7TvMh0bfPPTzCvtwIUCzASgpzYdi4lltOnwbFCeQwgDjY=" length="62738920"/>
<enclosure url="https://download.owncloud.com/desktop/stable/ownCloud-2.2.2.3472.pkg.tbz" sparkle:version="2.2.2.3472" type="application/octet-stream" sparkle:installationType="package" sparkle:edSignature="MC0CFQDmXR6biDmNVW7TvMh0bfPPTzCvtwIUCzASgpzYdi4lltOnwbFCeQwgDjY=" length="62738920"/>
<sparkle:minimumSystemVersion>11.0</sparkle:minimumSystemVersion>
</item>
</channel>
Expand Down Expand Up @@ -493,7 +493,7 @@ public function updateDataProvider(): array
<item>
<title>Nextcloud Client 2.2.2 (build 3472)</title>
<pubDate>Wed, 13 July 16 21:07:31 +0200</pubDate>
<enclosure url="https://download.owncloud.com/desktop/stable/ownCloud-2.2.2.3472.pkg.tbz" sparkle:version="2.2.2.3472" type="application/octet-stream" sparkle:edSignature="MC0CFQDmXR6biDmNVW7TvMh0bfPPTzCvtwIUCzASgpzYdi4lltOnwbFCeQwgDjY=" length="62738920"/>
<enclosure url="https://download.owncloud.com/desktop/stable/ownCloud-2.2.2.3472.pkg.tbz" sparkle:version="2.2.2.3472" type="application/octet-stream" sparkle:installationType="package" sparkle:edSignature="MC0CFQDmXR6biDmNVW7TvMh0bfPPTzCvtwIUCzASgpzYdi4lltOnwbFCeQwgDjY=" length="62738920"/>
<sparkle:minimumSystemVersion>11.0</sparkle:minimumSystemVersion>
</item>
</channel>
Expand All @@ -520,7 +520,7 @@ public function updateDataProvider(): array
<item>
<title>Nextcloud Client 2.2.2-rc2</title>
<pubDate>Wed, 13 July 16 21:07:31 +0200</pubDate>
<enclosure url="https://download.nextcloud.com/desktop/stable/Nextcloud-2.2.2-rc1.pkg.tbz" sparkle:version="2.2.2-rc2" type="application/octet-stream" sparkle:edSignature="MC0CFQDmXR6biDmNVW7TvMh0bfPPTzCvtwIUCzASgpzYdi4lltOnwbFCeQwgDjY=" length="62738920"/>
<enclosure url="https://download.nextcloud.com/desktop/stable/Nextcloud-2.2.2-rc1.pkg.tbz" sparkle:version="2.2.2-rc2" type="application/octet-stream" sparkle:installationType="package" sparkle:edSignature="MC0CFQDmXR6biDmNVW7TvMh0bfPPTzCvtwIUCzASgpzYdi4lltOnwbFCeQwgDjY=" length="62738920"/>
<sparkle:minimumSystemVersion>11.0</sparkle:minimumSystemVersion>
</item>
</channel>
Expand All @@ -547,7 +547,7 @@ public function updateDataProvider(): array
<item>
<title>Nextcloud Client 2.2.2-rc2</title>
<pubDate>Wed, 13 July 16 21:07:31 +0200</pubDate>
<enclosure url="https://download.nextcloud.com/desktop/stable/Nextcloud-2.2.2-rc1.pkg.tbz" sparkle:version="2.2.2-rc2" type="application/octet-stream" sparkle:edSignature="MC0CFQDmXR6biDmNVW7TvMh0bfPPTzCvtwIUCzASgpzYdi4lltOnwbFCeQwgDjY=" length="62738920"/>
<enclosure url="https://download.nextcloud.com/desktop/stable/Nextcloud-2.2.2-rc1.pkg.tbz" sparkle:version="2.2.2-rc2" type="application/octet-stream" sparkle:installationType="package" sparkle:edSignature="MC0CFQDmXR6biDmNVW7TvMh0bfPPTzCvtwIUCzASgpzYdi4lltOnwbFCeQwgDjY=" length="62738920"/>
<sparkle:minimumSystemVersion>11.0</sparkle:minimumSystemVersion>
</item>
</channel>
Expand Down Expand Up @@ -670,7 +670,7 @@ public function updateDataProvider(): array
<item>
<title>Nextcloud Client 2.0.0 (build 0000)</title>
<pubDate>Wed, 13 July 16 21:07:31 +0200</pubDate>
<enclosure url="https://download.nextcloud.com/desktop/stable/Nextcloud-2.0.0.0000.pkg.tbz" sparkle:version="2.0.0.0000" type="application/octet-stream" sparkle:edSignature="MC0CFQDmXR6biDmNVW7TvMh0bfPPTzCvtwIUCzASgpzYdi4lltOnwbFCeQwgDjY=" length="62738920"/>
<enclosure url="https://download.nextcloud.com/desktop/stable/Nextcloud-2.0.0.0000.pkg.tbz" sparkle:version="2.0.0.0000" type="application/octet-stream" sparkle:installationType="package" sparkle:edSignature="MC0CFQDmXR6biDmNVW7TvMh0bfPPTzCvtwIUCzASgpzYdi4lltOnwbFCeQwgDjY=" length="62738920"/>
<sparkle:minimumSystemVersion>11.0</sparkle:minimumSystemVersion>
</item>
</channel>
Expand Down Expand Up @@ -841,7 +841,7 @@ public function updateDataProvider(): array
<item>
<title>Nextcloud Client 2.2.2 (build 3472)</title>
<pubDate>Wed, 13 July 16 21:07:31 +0200</pubDate>
<enclosure url="https://download.owncloud.com/desktop/stable/ownCloud-2.2.2.3472.pkg.tbz" sparkle:version="2.2.2.3472" type="application/octet-stream" sparkle:edSignature="MC0CFQDmXR6biDmNVW7TvMh0bfPPTzCvtwIUCzASgpzYdi4lltOnwbFCeQwgDjY=" length="62738920"/>
<enclosure url="https://download.owncloud.com/desktop/stable/ownCloud-2.2.2.3472.pkg.tbz" sparkle:version="2.2.2.3472" type="application/octet-stream" sparkle:installationType="package" sparkle:edSignature="MC0CFQDmXR6biDmNVW7TvMh0bfPPTzCvtwIUCzASgpzYdi4lltOnwbFCeQwgDjY=" length="62738920"/>
<sparkle:minimumSystemVersion>11.0</sparkle:minimumSystemVersion>
</item>
</channel>
Expand Down

0 comments on commit 092be1c

Please sign in to comment.