Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable audit by configuration #163 #192

Closed
wants to merge 1 commit into from
Closed

Conversation

fgsl
Copy link
Contributor

@fgsl fgsl commented Apr 20, 2018

  • audit of following actions:

  • user X created circle Z;

  • user X removed circle Z;

  • user X change name of circle Z for circle W;

  • user X was added to circle U by user Z;

  • user X shared file/folder with circle Y;

  • user X, that created circle, unshared file/folder with circle Y

  • member X accepted invitation to circle Y by user Z;

  • member X left circle Y;

  • user X change role of member Y in circle Z for W.

  • user X was invited to circle U by user Z

  • configuration by circles_enable_audit in config.php

Signed-off-by: Flávio Gomes da Silva Lisboa flavio.lisboa@serpro.gov.br

@ArtificialOwl
Copy link
Member

Hello,

could you rework your PR ?

First, there is already some events dispatched, so if some are missing, please use the same structure/code.
Then if it is just to log on nextcloud.log, you don't need to use events/hooks, just generate the debug line at the right place. Also, there is no need for settings option.

Regards,

@fgsl
Copy link
Contributor Author

fgsl commented Jun 4, 2018

Hello @daita .

Great! If is possible (allowable) to log directly, it's better. I will refactor code removing events/hooks and specific configuration.

Hello,

could you rework your PR ?

First, there is already some events dispatched, so if some are missing, please use the same structure/code.
Then if it is just to log on nextcloud.log, you don't need to use events/hooks, just generate the debug line at the right place. Also, there is no need for settings option.

Regards,

@fgsl
Copy link
Contributor Author

fgsl commented Jun 7, 2018

I have reviewed all this implementation, but when I tested I found an error introduced by PR 203. Then I sent PR 208 to fix it. Only after this fixing I can submit a new PR for audit.

@fgsl
Copy link
Contributor Author

fgsl commented Jun 18, 2018

@daita, I did what you asked me. I have open a new PR: #210

@ArtificialOwl
Copy link
Member

Thanks, I will have a look into it this week

- audit of following actions:
- user X created circle Z;
- user X removed circle Z;
- user X change name of circle Z for circle W;
- user X was added to circle U by user Z;
- user X shared file/folder with circle Y;
- user X, that created circle, unshared file/folder with circle Y
- member X accepted invitation to circle Y by user Z;
- member X left circle Y;
- user X change role of member Y in circle Z for W.
- user X was invited to circle U by user Z

- configuration by circles_enable_audit in config.php

Signed-off-by: Flávio Gomes da Silva Lisboa <flavio.lisboa@serpro.gov.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants