Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore empty fileIds #1615

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Conversation

ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Jun 27, 2024

should fix generation of empty AND (()) request

Closes nextcloud/server#46196

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@brotkastn
Copy link

It may be worth to push this fix with high priority, seeing the files list come back empty is quite scary and might result in lost trust (see #46139 )

@solracsf
Copy link
Member

solracsf commented Jul 3, 2024

Error also present on v28, so target v30 and backport v29 + v28?

@floss4good
Copy link

If it helps, I tested this fix on Nextcloud 27.1.11 and 29.0.3 and posted my feedback on server#46196.

@joshtrichards
Copy link
Member

/backport to stable29

@joshtrichards
Copy link
Member

/backport to stable28

@joshtrichards joshtrichards merged commit 4ad28ea into master Jul 6, 2024
21 checks passed
@solracsf solracsf deleted the fix/noid/ignore-empty-filesids branch July 6, 2024 10:55
@floss4good
Copy link

Are you going to include this fix also in Nextcloud 27.1.12 milestone or is this app currently released only bundled within Nextcloud server (that has reached EOL for version 27)?

@joshtrichards
Copy link
Member

It's only released with Server.

@floss4good
Copy link

Thanks; then I guess you should delete that milestone (# 112).

@tobiasKaminsky
Copy link
Member

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: SQL syntax error ')) AND (sh.parent IS NULL)'
8 participants