Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download permissions on share for internal/external members #1357

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

ArtificialOwl
Copy link
Member

manage allow download on shares to Circles using the same mechanism that internal shares and shareByMail.

  • local account as members of a Circle will not be able to download the shared content,
  • remote account (mail address) as members will not be able to see the download button.

the attributes is stored/converted the same way than in core.

lib/Db/ShareWrapperRequest.php Outdated Show resolved Hide resolved
lib/Db/ShareWrapperRequest.php Outdated Show resolved Hide resolved
lib/Db/ShareWrapperRequest.php Outdated Show resolved Hide resolved
lib/Db/ShareWrapperRequest.php Outdated Show resolved Hide resolved
lib/Model/ShareWrapper.php Outdated Show resolved Hide resolved
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl
Copy link
Member Author

/backport to stable27

@ArtificialOwl
Copy link
Member Author

/backport to stable26

@ArtificialOwl ArtificialOwl merged commit 4cc1c53 into master Sep 2, 2023
19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the enh/noid/download-permissions branch September 2, 2023 11:59
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants