Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose LEVEL_*, STATUS_* and TYPE_* constants in API #466

Closed
mejo- opened this issue Jul 23, 2020 · 3 comments
Closed

Expose LEVEL_*, STATUS_* and TYPE_* constants in API #466

mejo- opened this issue Jul 23, 2020 · 3 comments

Comments

@mejo-
Copy link
Member

mejo- commented Jul 23, 2020

The circles app uses those constants internally and its values are required for several API-exposed functions. Therefore it would be a good idea to expose the constants in the APIs themselves, no?
@mejo-
Copy link
Member Author

mejo- commented Jul 23, 2020

If you agree, then I could prepare a PR to do so.

@ArtificialOwl
Copy link
Member

yes please !

mejo- added a commit to mejo-/circles that referenced this issue Aug 7, 2020
@mejo-
Expose circle and member constants via PHP API (Fixes: nextcloud#466)
227899d
mejo- added a commit to mejo-/circles that referenced this issue Aug 7, 2020
@mejo-
Expose circle and member constants via PHP API (Fixes: nextcloud#466)
f284e0d 
Signed-off-by: Jonas Meurer <jonas@freesources.org>
@mejo-
Copy link
Member Author

mejo- commented Aug 7, 2020

Perfect. PR is at #472 😊

ArtificialOwl added a commit that referenced this issue Aug 10, 2020
@ArtificialOwl
Merge pull request #472 from mejo-/api_expose_consts
f8c3ab2 
Expose circle and member constants via PHP API (Fixes: #466)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArtificialOwl @mejo-