Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: scope global sidebar styles to the app" #6091

Closed
wants to merge 1 commit into from

Conversation

miaulalala
Copy link
Contributor

This reverts commit 2460c53.

The fix broke the sidebar tabs.

@miaulalala miaulalala added the 3. to review Waiting for reviews label Jun 28, 2024
@miaulalala miaulalala added this to the v4.8.0 milestone Jun 28, 2024
@miaulalala miaulalala requested a review from st3iny June 28, 2024 09:55
@miaulalala miaulalala self-assigned this Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.71%. Comparing base (9cb56bd) to head (4f21cd7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6091   +/-   ##
=========================================
  Coverage     29.71%   29.71%           
  Complexity      914      914           
=========================================
  Files           287      287           
  Lines         13835    13835           
  Branches       2163     2153   -10     
=========================================
  Hits           4111     4111           
- Misses         9409     9410    +1     
+ Partials        315      314    -1     
Flag Coverage Δ
javascript 15.57% <ø> (ø)
php 58.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This reverts commit 2460c53.

Signed-off-by: Anna Larch <anna@nextcloud.com>
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix at #6087

The revert will break Talk!

@st3iny
Copy link
Member

st3iny commented Jun 28, 2024

I forgot to backport the fix: #6093

Sorry the heat is killing me ... 🔥

@miaulalala miaulalala closed this Jun 28, 2024
@st3iny st3iny deleted the rever/global-styles-fix branch June 28, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Development

Successfully merging this pull request may close these issues.

2 participants