Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): implement app config to hide resources tab #5385

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Aug 1, 2023

Revival of #4401

Tested and works.

This PR was approved and then lost. I rebased it and fixed all conflicts.

@st3iny st3iny added 3. to review Waiting for reviews enhancement New feature request Feature: Editor labels Aug 1, 2023
@st3iny st3iny added this to the v4.5.0 milestone Aug 1, 2023
@st3iny st3iny self-assigned this Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.02% 🎉

Comparison is base (32fa3fa) 22.71% compared to head (28d672c) 22.74%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5385      +/-   ##
============================================
+ Coverage     22.71%   22.74%   +0.02%     
  Complexity      372      372              
============================================
  Files           237      237              
  Lines         11679    11684       +5     
  Branches       2270     2270              
============================================
+ Hits           2653     2657       +4     
- Misses         9026     9027       +1     
Flag Coverage Δ
javascript 13.95% <50.00%> (+<0.01%) ⬆️
php 65.47% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/views/Calendar.vue 0.00% <ø> (ø)
src/views/EditSidebar.vue 0.00% <0.00%> (ø)
src/store/settings.js 88.59% <100.00%> (+0.10%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/views/Calendar.vue Outdated Show resolved Hide resolved
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the feat/editor/hide-resources branch from 525cf3c to 28d672c Compare August 1, 2023 15:35
@st3iny st3iny merged commit 98cadcd into main Aug 1, 2023
41 checks passed
@st3iny st3iny deleted the feat/editor/hide-resources branch August 1, 2023 15:45
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 1, 2023
@st3iny
Copy link
Member Author

st3iny commented Aug 1, 2023

Thanks to @pboguslawski for the implementation.

@scharmach
Copy link

@st3iny Maybe I'm completely blind, but how do I actually use this?

I can't find anything under "Calendar settings" within the app and I'm not sure where and how to look to configure this elsewhere.

@st3iny
Copy link
Member Author

st3iny commented Sep 25, 2023

@st3iny Maybe I'm completely blind, but how do I actually use this?

I can't find anything under "Calendar settings" within the app and I'm not sure where and how to look to configure this elsewhere.

You can configure this by setting an app config: occ config:app:set calendar showResources --value=no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature request Feature: Editor
Projects
Development

Successfully merging this pull request may close these issues.

3 participants