Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate calendar event #4300

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Duplicate calendar event #4300

merged 1 commit into from
Jun 21, 2022

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jun 18, 2022 •
edited
Loading

Close #113

Based on #2621
Supersedes #2621
Close #2621

Signed-off-by: szaimen szaimen@e.mail.de

For my own testing 
docker run -it \
-e CALENDAR_BRANCH=enh/113/duplicate-event \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.130 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added 2. developing Work in progress enhancement New feature request labels Jun 18, 2022
@codecov
Copy link

codecov bot commented Jun 18, 2022 •
edited
Loading

Codecov Report

Merging #4300 (655d89b) into main (cb9590c) will decrease coverage by 0.16%.
The diff coverage is 2.17%.

❗ Current head 655d89b differs from pull request most recent head 04c0f9e. Consider uploading reports for the commit 04c0f9e to get more accurate results

@@             Coverage Diff              @@
##               main    #4300      +/-   ##
============================================
- Coverage     29.59%   29.43%   -0.17%     
  Complexity      330      330              
============================================
  Files           221      221              
  Lines          7659     7705      +46     
  Branches       1014     1019       +5     
============================================
+ Hits           2267     2268       +1     
- Misses         5392     5437      +45
Flag Coverage Δ
javascript 20.54% <2.17%> (-0.14%) ⬇️
php 68.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onents/AppNavigation/Settings/ShortcutOverview.vue 0.00% <ø> (ø)
src/mixins/EditorMixin.js 0.00% <0.00%> (ø)
src/store/calendarObjectInstance.js 0.00% <0.00%> (ø)
src/views/EditSidebar.vue 0.00% <0.00%> (ø)
src/views/EditSimple.vue 0.00% <0.00%> (ø)
src/models/event.js 57.40% <4.16%> (-42.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb9590c...04c0f9e. Read the comment docs.

@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 18, 2022
@szaimen szaimen marked this pull request as ready for review June 18, 2022 14:07
@szaimen szaimen mentioned this pull request Jun 18, 2022
Closed
@rogelio-o @st3iny
Duplicate calendar event
04c0f9e 
Signed-off-by: rogelio-o <yo@rogelioorts.com>
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
st3iny approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. I improved the documentation a bit and renamed the actual cloning method from map... to copyFrom...Into... because it confused me.

@st3iny st3iny mentioned this pull request Jun 21, 2022
Closed
9 tasks
@st3iny st3iny enabled auto-merge June 21, 2022 11:35
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 21, 2022
@st3iny st3iny added this to the v3.5.0 milestone Jun 21, 2022
@st3iny st3iny disabled auto-merge June 21, 2022 11:38
@st3iny st3iny merged commit 39709a9 into main Jun 21, 2022
@st3iny st3iny deleted the enh/113/duplicate-event branch June 21, 2022 11:47
@szaimen
Copy link
Contributor Author

szaimen commented Jun 21, 2022

🎉🎉🎉🎉🎉

@xeruf
Copy link

xeruf commented Oct 15, 2022

Using calendar 3.5.0, I cannot find this option?
image

@st3iny
Copy link
Member

st3iny commented Oct 17, 2022

@xeruf It may not work for recurring events if no recurrence exception can be created. Try it with regular events.

@xeruf
Copy link

xeruf commented Nov 17, 2022 •
edited
Loading

Have it now, thank you :)
One weird behavior: When I duplicate an event off a recurring event, I cannot configure recurrence as it says that the event is already a recurrence exception.
But when I save the duplicated event and select it again, it is suddenly an independent event and can be configured to recur.

@st3iny st3iny mentioned this pull request Dec 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@GretaD GretaD Awaiting requested review from GretaD

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature request
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

Duplicate event
4 participants
@szaimen @xeruf @st3iny @rogelio-o