add collaboration type

[blizzz]

Depends on nextcloud/server#6328, used in nextcloud/circles#126

It looks fairly broad and complex… because "collaboration" is a pretty wide term and I've no idea what else could come there in future (or not).

shareType (line 461) could be an enumeration as well, however it would mean naming constants here and have a coupling to code. Not sure this is necessary, but if worthwhile I can change this. Opinions welcome about it.

[coveralls]

Coverage increased (+0.002%) to 97.545% when pulling 05d1393 on add-collaboration into 87c3421 on master.

[BernhardPosselt]

Needs a description of what the tag actually does here in the docs: http://nextcloudappstore.readthedocs.io/en/latest/developer.html#info-xml

See https://github.com/nextcloud/appstore/blob/master/docs/developer.rst

As for the structure: the nesting seems a bit excessive given that you only want to be able to register search plugins. Maybe its possible to bring it down to something like (just some playing around, do not know the usecase enough for that):

<collaboration>
    <plugin type="search" sharing="SHARE_TYPE_CIRCLE">OCA\Circles\Collaboration\v1\CollaboratorSearchPlugin</plugin>
</collaboration>

As for the share type: is there a finite number of types? If so, use an enumeration.

[blizzz]

@BernhardPosselt ty! Your remarks are addressed

[coveralls]

Coverage decreased (-0.03%) to 97.516% when pulling a094d19 on add-collaboration into 87c3421 on master.

[BernhardPosselt]

Very small nitpick: XML and HTML usually uses an-attribute instead of anAttribute. Feel free to change it if you want to ;)

[blizzz]

Very small nitpick: XML and HTML usually uses an-attribute instead of anAttribute. Feel free to change it if you want to ;)

Uff… did not pay attention to this. Perhaps, also because minOccurs, maxOccurs or xsi:noNamespaceSchemaLocation for instance do not follow this style as well. I acknowledge conventions and consistency however → will change this.

[coveralls]

Coverage decreased (-0.03%) to 97.516% when pulling 9137420 on add-collaboration into 87c3421 on master.