Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly import donation tag attributes #1492

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

edward-ly
Copy link
Contributor

See my Zulip integration app for an example. This is what is displayed right now vs. what it should look like with this PR.

Before After
Screenshot 2024-09-19 at 11-22-26 Zulip Integration - Apps - App Store - Nextcloud Screenshot 2024-09-19 at 11-22-44 Zulip Integration - Apps - App Store - Nextcloud

Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Edward Ly <contact@edward.ly>
Copy link
Member

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edward-ly edward-ly merged commit cb10c0a into master Sep 19, 2024
9 checks passed
@edward-ly edward-ly deleted the fix/donation-import branch September 19, 2024 09:38
Copy link

github-actions bot commented Oct 4, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants