(feat): Allow any docker network for HTTPS(remote) install type #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-nc
force-pushed
the
feat/exapp-host-network-rework
branch
2 times, most recently
from
0425a55 to
d2829ae
Compare
oleksandr-nc
force-pushed
the
feat/exapp-host-network-rework
branch
8 times, most recently
from
49af885 to
74cb1ed
Compare
kyteinsky
reviewed
Jan 7, 2025
oleksandr-nc
force-pushed
the
feat/exapp-host-network-rework
branch
from
c6a0748 to
8b22a61
Compare
kyteinsky
approved these changes
Jan 7, 2025
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
andrey18106
force-pushed
the
feat/exapp-host-network-rework
branch
from
f82e8df to
60f7752
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
andrey18106
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for ExApp installations when the protocol type is
httpsand the network daemon type is not equal tohostvalue.Additionally, deployment tests have been modified to include more information to help detect problems faster.
Required for applications like ContextChat or Flow that contain a PgSQL database that used default port that may conflict with each other without network isolation.
Note: this PR does not include a modification of the interface part where these restrictions will be removed. This should be presented in a separate PR, you can check it through console commands by creating a daemon or by editing the value in the DB manually.