Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create holiday_calendars.csr #504

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Create holiday_calendars.csr #504

merged 1 commit into from
Mar 2, 2022

Conversation

tcitworld
Copy link
Member

Holiday calendars is an app listing links to public calendars representing the holidays and allowing to subscribe to them

Source: https://framagit.org/framasoft/nextcloud/holiday_calendars

@vitormattos
Copy link
Contributor

@tcitworld can you put the csr file inside of folder with the same name of app_id?

Example:

holiday_calendars/holiday_calendars.csr

@vitormattos
Copy link
Contributor

To make clean the log, will be good amend to last commit

Holiday calendars is an app listing links to public calendars representing the holidays and allowing to subscribe to them

Source: https://framagit.org/framasoft/nextcloud/holiday_calendars

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld
Copy link
Member Author

Fixed 🙈

@vitormattos
Copy link
Contributor

All is ok.
Only suggestions:

  • fill the readme with description of app
  • add screenshots

@vitormattos vitormattos merged commit f620cb9 into master Mar 2, 2022
@vitormattos vitormattos deleted the tcitworld-patch-1 branch March 2, 2022 12:55
@vitormattos
Copy link
Contributor

Here: c01c823

@vitormattos
Copy link
Contributor

What do you think about to open an issue at nextcloud/calendar to suggest to migrate this feature to nextcloud/calendar?

@tcitworld
Copy link
Member Author

Not really, this is a 3rd party app as intended.

nextcloud/calendar#962

@Tealk
Copy link

Tealk commented Mar 5, 2022

where does the information about the holidays come from?

@nickvergessen
Copy link
Member

Please ask in the repository of the app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants