Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unnecessary block statement in nc-apps.ymls. #235

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

marioqxx
Copy link
Contributor

@marioqxx marioqxx commented Mar 12, 2023

This is a simple cleanup. It removes an unnecessary block-statement that has remained. The mainy changes it suggests to include are only removal of leading spaces for correct indentation.

wiktor2200
wiktor2200 previously approved these changes Mar 12, 2023
Copy link
Collaborator

@wiktor2200 wiktor2200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@staticdev
Copy link
Collaborator

staticdev commented Mar 12, 2023

@marioqxx yto merge we need you to do a git commit --amend and add your email to commit message to pass the DCO. After that you can git push -f.

Copy link
Collaborator

@staticdev staticdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to pass DCO.

Signed-off-by: marioqxx <82337956-marioqxx@users.noreply.github.com>
@marioqxx
Copy link
Contributor Author

@marioqxx yto merge we need you to do a git commit --amend and add your email to commit message to pass the DCO. After that you can git push -f.

@staticdev: Thanks again for help. I needed to use commit -s --amend.

@wiktor2200 wiktor2200 added the refactoring Refactoring label Mar 12, 2023
@wiktor2200 wiktor2200 requested a review from staticdev March 12, 2023 15:39
@staticdev staticdev merged commit 93dd139 into nextcloud:main Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants