Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): introducing dark-mode and refactor some templates and css #5397

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(ui): introducing dark-mode and refactor some templates and css #5397

wants to merge 1 commit into from
+939 −678

Conversation

ernolf
Copy link
Collaborator

@ernolf ernolf commented Oct 8, 2024

Introducing dark-mode

AIO-dark-mode.webm

@szaimen szaimen added 3. to review Waiting for reviews design Related to design, interface, interaction design, UX, etc. enhancement New feature or request labels Oct 8, 2024
@szaimen szaimen added this to the next milestone Oct 8, 2024
@szaimen
Copy link
Collaborator

szaimen commented Oct 9, 2024

Woow!!! Many thanks @ernolf for this amazing contribution🎉😊

szaimen
szaimen reviewed Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some remarks though and leave it further down but looks really great already. Thanks again! :)

php/templates/already-installed.twig Outdated Show resolved Hide resolved
php/templates/containers.twig Outdated Show resolved Hide resolved
@szaimen szaimen changed the title feat(ui): introducing dark-mode feat(ui): introducing dark-mode and refactor some template details Oct 9, 2024
@sorbaugh
Copy link

sorbaugh commented Oct 9, 2024

Looking good!

docjyJ
docjyJ requested changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@docjyJ docjyJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but it's cool!

php/public/style.css Show resolved Hide resolved
php/public/toggle-dark-mode.js Show resolved Hide resolved
php/templates/already-installed.twig Outdated Show resolved Hide resolved
php/templates/includes/containers-main.twig Outdated Show resolved Hide resolved
php/public/toggle-dark-mode.js Show resolved Hide resolved
@docjyJ
Copy link
Collaborator

docjyJ commented Oct 9, 2024

The ideal would be to have a Vuejs front and a JSON API 🫢 🙄

@docjyJ
Copy link
Collaborator

docjyJ commented Oct 9, 2024

If you don't know, on this site there are lots of tips including sync with OS

https://css-tricks.com/a-complete-guide-to-dark-mode-on-the-web/

@szaimen
Copy link
Collaborator

szaimen commented Oct 9, 2024 •
edited
Loading

The ideal would be to have a Vuejs front and a JSON API 🫢 🙄

I am not sure about this. I think vuejs is overkill for such a small site. And it adds maintainability issues imho.

@szaimen szaimen changed the title feat(ui): introducing dark-mode and refactor some template details feat(ui): introducing dark-mode and refactor some template details and css Oct 9, 2024
@szaimen szaimen modified the milestones: v9.7.0, next Oct 10, 2024
@szaimen
Copy link
Collaborator

szaimen commented Oct 10, 2024 •
edited
Loading

Btw @ernolf i think we need to increase v2 for upgrade scenarios:

all-in-one/php/templates/layout.twig

Line 4 in a647d10

<link rel="stylesheet" href="/style.css?v2" media="all" />

@docjyJ

This comment was marked as resolved.

Sign in to view
@szaimen

This comment was marked as resolved.

Sign in to view
@docjyJ

This comment was marked as resolved.

Sign in to view
@szaimen

This comment was marked as resolved.

Sign in to view
@docjyJ

This comment was marked as resolved.

Sign in to view
@szaimen

This comment was marked as resolved.

Sign in to view
@docjyJ

This comment was marked as resolved.

Sign in to view
@szaimen

This comment was marked as resolved.

Sign in to view
@szaimen
Copy link
Collaborator

szaimen commented Oct 10, 2024

Lets maybe discuss this in a separate issue. Do you want to create an issue?

@ernolf
Copy link
Collaborator Author

ernolf commented Oct 10, 2024

Btw @ernolf i think we need to increase v2 for upgrade scenarios:

all-in-one/php/templates/layout.twig

Line 4 in a647d10

<link rel="stylesheet" href="/style.css?v2" media="all" />

See bf47628

@ernolf
feat(ui): introducing dark-mode and refactor some template details an…
1f144b9 
…d css

- chore: increase to 9.7.0 - reconcile with main after rebase
- chore: reconcile fixes to containers.twig from main after rebase
- refactor(layout): increment CSS version from v2 to v3

Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
@szaimen szaimen requested a review from docjyJ October 10, 2024 20:51
szaimen
szaimen approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot 💙
This needs to wait for the next stable release though before it can be merged (ca. 1 week)

docjyJ
docjyJ approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@docjyJ docjyJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szaimen szaimen changed the title feat(ui): introducing dark-mode and refactor some template details and css feat(ui): introducing dark-mode and refactor some templates and css Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@docjyJ docjyJ docjyJ approved these changes

@szaimen szaimen szaimen approved these changes

@Zoey2936 Zoey2936 Awaiting requested review from Zoey2936

Assignees
No one assigned
Labels
3. to review Waiting for reviews design Related to design, interface, interaction design, UX, etc. enhancement New feature or request
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.
4 participants
@ernolf @szaimen @sorbaugh @docjyJ