Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the development environment #5040

Merged
merged 6 commits into from
Jul 26, 2024
Merged

Improve the development environment #5040

merged 6 commits into from
Jul 26, 2024

Conversation

docjyJ
Copy link
Collaborator

@docjyJ docjyJ commented Jul 25, 2024 •
edited
Loading

  • Delete the unnecessary .idea folder
  • Added some commands to start AIO application development
  • Adding tools used in development requirements
  • Updated workflows that no longer need to install tools
  • adjust .gitignore file

@docjyJ
fix
31162a2 
Signed-off-by: Jean-Yves <7360784+docjyJ@users.noreply.github.com>
@docjyJ docjyJ added 3. to review Waiting for reviews enhancement New feature or request labels Jul 25, 2024
@docjyJ docjyJ requested a review from szaimen July 25, 2024 16:28
@docjyJ docjyJ self-assigned this Jul 25, 2024
szaimen
szaimen reviewed Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for tackling this @docjyJ! :)

Some comments below:

php/README.md Outdated Show resolved Hide resolved
php/README.md Outdated Show resolved Hide resolved
php/composer.lock Outdated Show resolved Hide resolved
php/composer.lock Outdated Show resolved Hide resolved
@szaimen
Copy link
Collaborator

szaimen commented Jul 26, 2024

Btw, @docjyJ what about your changes to the gitignore file? https://github.com/nextcloud/all-in-one/pull/5016/files#diff-3928fe1f5e72c4886b92733a2978fab5c1b036c7fd23e652fe9dd049572d2940

@szaimen szaimen added this to the next milestone Jul 26, 2024
szaimen
szaimen reviewed Jul 26, 2024
View reviewed changes
php/composer.json Outdated Show resolved Hide resolved
@docjyJ @szaimen
Update php/composer.json
d30af69 
Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Jean-Yves <7360784+docjyJ@users.noreply.github.com>
@docjyJ
Copy link
Collaborator Author

docjyJ commented Jul 26, 2024

Btw, @docjyJ what about your changes to the gitignore file? https://github.com/nextcloud/all-in-one/pull/5016/files#diff-3928fe1f5e72c4886b92733a2978fab5c1b036c7fd23e652fe9dd049572d2940

data/*
session/*
!data/.gitkeep
!session/.gitkeep

This keeps the directory but prevents committing all session files created at runtime.
These files don't have a template to blacklist them, so I whitelist the .gitkeep.

The vendor is like node_module for composer, it must be in gitigniore.

And .idea, I don't know why it was committed...

@szaimen
Copy link
Collaborator

szaimen commented Jul 26, 2024

Btw, @docjyJ what about your changes to the gitignore file? https://github.com/nextcloud/all-in-one/pull/5016/files#diff-3928fe1f5e72c4886b92733a2978fab5c1b036c7fd23e652fe9dd049572d2940

data/*
session/*
!data/.gitkeep
!session/.gitkeep

This keeps the directory but prevents committing all session files created at runtime. These files don't have a template to blacklist them, so I whitelist the .gitkeep.

The vendor is like node_module for composer, it must be in gitigniore.

And .idea, I don't know why it was committed...

sounds good. I'd recommend to commit the changes to the gitignore file to this branch :)

@docjyJ
Copy link
Collaborator Author

docjyJ commented Jul 26, 2024

Btw, @docjyJ what about your changes to the gitignore file? https://github.com/nextcloud/all-in-one/pull/5016/files#diff-3928fe1f5e72c4886b92733a2978fab5c1b036c7fd23e652fe9dd049572d2940

data/*
session/*
!data/.gitkeep
!session/.gitkeep

This keeps the directory but prevents committing all session files created at runtime. These files don't have a template to blacklist them, so I whitelist the .gitkeep.

The vendor is like node_module for composer, it must be in gitigniore.

And .idea, I don't know why it was committed...

sounds good. I'd recommend to commit the changes to the gitignore file to this branch :)

Yes, I'll split into two branches.

@docjyJ
Copy link
Collaborator Author

docjyJ commented Jul 26, 2024

My bad, I forgot to commit the .gitignore.

@szaimen szaimen mentioned this pull request Jul 26, 2024
Closed
18 tasks
@docjyJ
Update .gitignore
1accb8f 
Signed-off-by: Jean-Yves <7360784+docjyJ@users.noreply.github.com>
@docjyJ
Update composer.lock
5dbcf17 
Signed-off-by: Jean-Yves <7360784+docjyJ@users.noreply.github.com>
@docjyJ
Update readeMe
68b5b77 
Signed-off-by: Jean-Yves <7360784+docjyJ@users.noreply.github.com>
@docjyJ
Fix gitignore
2c573b2 
Signed-off-by: Jean-Yves <7360784+docjyJ@users.noreply.github.com>
@docjyJ docjyJ requested a review from szaimen July 26, 2024 15:45
szaimen
szaimen approved these changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot! :)

@szaimen szaimen merged commit 73e4ea2 into nextcloud:main Jul 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

Assignees

@docjyJ docjyJ

Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
v9.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@docjyJ @szaimen