Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check - move to head request instead of get request #3313

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Sep 7, 2023

Motivation: head requests are not counted in the pull limit afaik.

Also for #2667

Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request labels Sep 7, 2023
@szaimen szaimen added this to the next milestone Sep 7, 2023
Copy link

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍
Also see https://docs.docker.com/docker-hub/download-rate-limit/#definition-of-limits for reference about the definition.

@szaimen szaimen merged commit 99df9a3 into main Sep 12, 2023
6 checks passed
@szaimen szaimen deleted the enh/noid/head-request branch September 12, 2023 09:03
@szaimen
Copy link
Collaborator Author

szaimen commented Sep 13, 2023

This is now released with v7.2.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants