-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port settings to vue #861
Port settings to vue #861
Conversation
5ab2090
to
e94f71f
Compare
3d64175
to
823f91a
Compare
823f91a
to
73152d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Only details:
- Can you move the Mail/Push checkbox columns to the left again, so there’s not so much whitespace and it’s all nicely left-aligned like before? See screenshot below
- I can’t fully tell from the code – are the "Files", "Calendar, contacts and tasks" and "Other activities" marked up as h3?
I actually like it how @CarlSchwan did it, before the text alignment was a bit messy. |
73152d3
to
4955c6b
Compare
My main motivation to moving the checkbox to the right was to simplify the layout for screenreader (we don't have this two level of headers) and since the content is read from the left to the right the screenreader will first read the description of the checkbox and then tell the state of the mail notification and push notification for each row. This also solves some alignment issues with the content not at all left aligned. See screenshot
Done, this is now using h3 |
Cool, sounds good @CarlSchwan – do you mind decreasing the space between text and checkboxes a bit like @nimishavijay proposed? :) |
42a25ab
to
f344fc8
Compare
f344fc8
to
1453366
Compare
I still need one approval ;) |
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
1453366
to
757b97e
Compare
TODOs: