Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only apply .box and .group class styles if they are related to activity #351

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Feb 19, 2019

.group is also used in the files sharing dialog, so the css rules should only apply if they are activity related.

Found when testing nextcloud/server#14180

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@nickvergessen
Copy link
Member

Fine by me, I guess the whole file should receive an overhole after #263

@nickvergessen nickvergessen merged commit 2732443 into master Feb 19, 2019
@nickvergessen nickvergessen added this to the Nextcloud 16 milestone Feb 19, 2019
@nickvergessen nickvergessen deleted the bugfix/css-scope branch February 19, 2019 12:34
@nickvergessen
Copy link
Member

Backport to 15? Or is it only a problem on master?

@juliushaertl
Copy link
Member Author

Doesn't happen on 15 for me, so should be fine on master only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants