Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make linkable items clickable in HTML emails #248

Merged
merged 4 commits into from
Feb 26, 2018
Merged

Make linkable items clickable in HTML emails #248

merged 4 commits into from
Feb 26, 2018

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 15, 2018 •
edited
Loading

@nickvergessen
Make linkable items clickable in HTML emails
94aef23 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Only use public methods
551b94c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 14 milestone Feb 15, 2018
@nickvergessen
Make the URL in the email also clickable and add the name to the subject
5779102 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix unit tests
3ca6dec 
Signed-off-by: Joas Schilling <coding@schilljs.com>
MorrisJobke
MorrisJobke approved these changes Feb 26, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My 👍 still stands

@nickvergessen
Copy link
Member Author

Tests were fixed in #250

@nickvergessen nickvergessen merged commit 4aafd7e into master Feb 26, 2018
@nickvergessen nickvergessen deleted the feature/164/better-html-emails branch February 26, 2018 12:41
@nickvergessen nickvergessen mentioned this pull request Mar 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees
No one assigned
Labels
4. to release enhancement feature: email
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @MorrisJobke