Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing parameters when type is not "known" #1468

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

nickvergessen
Copy link
Member

Currently the fall backs from https://github.com/nextcloud/activity/blob/stable27/js/richObjectStringParser.js#L82-L87 are missing breaking activity of calendar, deck, talk, …

Before After
Bildschirmfoto vom 2023-12-18 15-44-37 Bildschirmfoto vom 2023-12-18 15-44-45

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

/backport 2a2939f,f77b042f423308688dd3e5d51840d80d9ff7126b to stable28

@susnux
Copy link
Contributor

susnux commented Dec 18, 2023

/compile amend

@artonge
Copy link
Collaborator

artonge commented Dec 18, 2023

Compilation CI seem off on this repo, not sure why

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
Copy link
Contributor

susnux commented Dec 18, 2023

Compilation CI seem off on this repo, not sure why

If you compile with the compile command it works, if you compile locally it does not :/

@artonge
Copy link
Collaborator

artonge commented Dec 18, 2023

If you compile with the compile command it works, if you compile locally it does not :/

From my experience, the compile command also fails.
Do you know the reason?

@nickvergessen
Copy link
Member Author

nickvergessen commented Dec 18, 2023

The main difference to other repos is this here uses vite not eslint/webpack for building?
As per https://github.com/nextcloud/activity/actions/runs/7249713557/job/19748361102#step:8:8 that seems to rename artefacts 🙈

@susnux
Copy link
Contributor

susnux commented Dec 18, 2023

that seems to rename

Assets are named by the content hash thus the content seems to be different between those builds

@susnux susnux merged commit 7618353 into master Dec 18, 2023
43 checks passed
@susnux susnux deleted the bugfix/noid/fix-missing-parameters branch December 18, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants