Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidebar): Only load chunk once #1363

Merged
merged 2 commits into from
Oct 12, 2023
Merged

fix(sidebar): Only load chunk once #1363

merged 2 commits into from
Oct 12, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Oct 12, 2023

Only load the chunk if needed (yes it might be cached but we do not need to try this).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Copy link
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it was loaded whenever the sidebar was opened ?

@susnux
Copy link
Contributor Author

susnux commented Oct 12, 2023

So it was loaded whenever the sidebar was opened ?

  1. when the DOM was loaded
  2. when the Sidemenu as registered, so the second one is not needed

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit 94f6c6e into master Oct 12, 2023
24 checks passed
@susnux susnux deleted the fix/only-load-once branch October 12, 2023 15:44
@@ -41,17 +41,21 @@ const activityTab = new OCA.Files.Sidebar.Tab({
iconSvg: LightningBolt,

async mount(el, fileInfo, context) {
const { default: ActivityTab } = await import(/* webpackPreload: true */ './views/ActivityTab.vue')
Copy link
Member

@marcelklehr marcelklehr Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, webpack doesn't cache the chunk here? That's weird.

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants