Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded margin after paragraphs #1231

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Jun 29, 2023

Fixes nextcloud/server#36978

Before After
image Screenshot from 2023-06-29 11-04-42

Works with:

  • Check Dashboard widgets with ARCToolkit
  • Check Dashboard widgets with Text spacing editor

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jun 29, 2023
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36978-When_text_spacing_is_increased,_the_contents_of_the_Recent_activity_tile_become_inaccessible branch from 618e10e to 9ff957f Compare June 29, 2023 09:19
Copy link
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is using https://github.com/nextcloud/nextcloud-vue-dashboard which is deprecated.

Can you try to use the components from https://github.com/nextcloud/nextcloud-vue?

src/views/Dashboard.vue Outdated Show resolved Hide resolved
@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Jun 29, 2023

Looks like this is using https://github.com/nextcloud/nextcloud-vue-dashboard which is deprecated.

Oh, yes, i've seen it some time ago ;( but missed it now. i will have a look

@skjnldsv skjnldsv force-pushed the fix/36978-When_text_spacing_is_increased,_the_contents_of_the_Recent_activity_tile_become_inaccessible branch 2 times, most recently from 59acf30 to 96a3a4b Compare June 29, 2023 20:32
@susnux susnux force-pushed the fix/36978-When_text_spacing_is_increased,_the_contents_of_the_Recent_activity_tile_become_inaccessible branch from 96a3a4b to ce8d19e Compare July 1, 2023 19:35
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Fenn-CS Fenn-CS enabled auto-merge July 1, 2023 20:57
@susnux susnux force-pushed the fix/36978-When_text_spacing_is_increased,_the_contents_of_the_Recent_activity_tile_become_inaccessible branch from 1d02544 to 8cbb46a Compare July 7, 2023 15:54
@susnux susnux disabled auto-merge July 7, 2023 15:55
@susnux
Copy link
Contributor

susnux commented Jul 7, 2023

(rebased)
Looks good, just to squash the !fixup commits and then this should ready to go :)

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36978-When_text_spacing_is_increased,_the_contents_of_the_Recent_activity_tile_become_inaccessible branch from 8cbb46a to 892e165 Compare August 10, 2023 14:57
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>

# Conflicts:
#	js/activity-160.js.LICENSE.txt
#	js/activity-160.js.map
#	js/activity-257.js.LICENSE.txt
#	js/activity-499.js
#	js/activity-499.js.map
#	js/activity-856.js.LICENSE.txt
#	js/activity-dashboard-lazy.js
#	js/activity-dashboard-lazy.js.map
#	js/activity-dashboard.js
#	js/activity-dashboard.js.map
#	js/activity-sidebar.js
#	js/activity-sidebar.js.map
#	package-lock.json
@susnux susnux force-pushed the fix/36978-When_text_spacing_is_increased,_the_contents_of_the_Recent_activity_tile_become_inaccessible branch from 892e165 to 7430c07 Compare August 11, 2023 12:02
…the_contents_of_the_Recent_activity_tile_become_inaccessible
@artonge
Copy link
Collaborator

artonge commented Aug 15, 2023

Rebased

@AndyScherzinger
Copy link
Member

@artonge Can I safely force-merge?

@AndyScherzinger AndyScherzinger merged commit cf6970e into master Aug 15, 2023
22 of 24 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/36978-When_text_spacing_is_increased,_the_contents_of_the_Recent_activity_tile_become_inaccessible branch August 15, 2023 12:53
@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants