Bump symfony/event-dispatcher to 5.4 #997
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I god error when I run
occ upgrade
after I did pull on server to get newest source from master branch. I have one app withsymfony/event-dispatcher
oncomposer.lock
using newest version of this package and I identified a problem of argument typing because the method GenericEvent->getArgument() on version >= 5 ofsymfony/event-dispatcher
have typed argument forcing to string and the GenericEventWrapper->getArgument() haven't typed argument.Suggested steps to solve the problem:
3rdparty
submoduleGenericEventWrapper
on serverGenericEventWrapper->getArgument
and cast the argument from int to stringWhat I did on this PR?