-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broker: add timezone to CANCEL messages #191
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgehrke
approved these changes
Dec 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch make sense and should be safe to back port imho 👍
/backport to stable15 |
/backport to stable14 |
hdijkema
added a commit
to hdijkema/server
that referenced
this pull request
Dec 18, 2018
…ud/3rdparty#191. Signed-off-by: hdijkema <hans@dykema.nl>
backport to stable15 in #196 |
backport to stable14 in #197 |
If DTSTART and/or DTEND and other times are specified with a TZID, some clients may fail reading the generated iCal data, since the VTIMEZONE definition is missing. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
d7e794a
to
cf19b25
Compare
1 task
hdijkema
added a commit
to hdijkema/server
that referenced
this pull request
Jan 14, 2019
…ud/3rdparty#191. Signed-off-by: hdijkema <hans@dykema.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref nextcloud/server#12946
If DTSTART and/or DTEND and other times are specified with a TZID, some clients
may fail reading the generated iCal data, since the VTIMEZONE definition is
missing.
I dont use Outlook but code make sense 🙈 Backport these changes to
stable15
?