Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump doctrine/dbal to 3.5.1 in master #1218

Closed
wants to merge 1 commit into from

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Nov 10, 2022

3.3.7 was needed for recent PHP support.
Bumping to latest version since next release is in a few month.

Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Copy link

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@nickvergessen
Copy link
Member

A yolo is not really acceptable in this case. We need passing tests in server and to review 3rdparty PRs it otherwise is enough to run the composer install locally to see if that would change files or create the same result

@come-nc come-nc closed this Nov 21, 2022
@susnux susnux deleted the fix/bump-doctrine/dbal-to-3.5.1-in-master branch April 4, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants