Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a php tag to the nextcloud container #19

Merged
merged 1 commit into from
May 23, 2022
Merged

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented May 16, 2022

Signed-off-by: szaimen szaimen@e.mail.de

Signed-off-by: szaimen <szaimen@e.mail.de>
@juliusknorr
Copy link

Wouldn't it make sense to do all changes against the main repository and just push the tags to the releases one once releasing?

@szaimen
Copy link
Collaborator Author

szaimen commented May 16, 2022

Wouldn't it make sense to do all changes against the main repository and just push the tags to the releases one once releasing?

Yes, this is how we are doing it :)

Changes are only pushed to this repo for creating and pushing new containers...
I documented most of this here if you want to get an overview: nextcloud/all-in-one#180

@juliusknorr
Copy link

But then you could also open this PR against the main repo or? Would make it a bit easier to only have one place for changes and everything on the releases is handled through the automated sync. But not a blocker of course :)

@szaimen
Copy link
Collaborator Author

szaimen commented May 16, 2022

But then you could also open this PR against the main repo or? Would make it a bit easier to only have one place for changes and everything on the releases is handled through the automated sync. But not a blocker of course :)

Ah that is what you mean :)

No, we have completely different workflows for the different repos and that also makes sense, imo :)

Thanks for the approval, btw! :)

@juliusknorr
Copy link

We also have that for app releases with a condition to only run them on the releases https://github.com/nextcloud/deck/blob/master/.github/workflows/appstore-build-publish.yml#L20 but fine with me :)

@szaimen
Copy link
Collaborator Author

szaimen commented May 16, 2022

We also have that for app releases with a condition to only run them on the releases https://github.com/nextcloud/deck/blob/master/.github/workflows/appstore-build-publish.yml#L20 but fine with me :)

all right that would indeed be a possibility but having separate workflows in each repo is a bit easier to work with, imo :)

@szaimen szaimen merged commit 484b876 into main May 23, 2022
@szaimen szaimen deleted the enh/noid/nextcloud-php-tag branch May 23, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants