-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rules to prevent prettier to run #475
Conversation
Signed-off-by: Christian Wolf <github@christianwolf.email>
Do you have a reproduction example for the described issue? |
Hey @ShGKme. If you peek into the history, you will see that I merged prettier twice as I thought I managed to fix it in the meantime. A more detailed explanation of the problem was written by SysKeeper in this form thread. This thread had additional information and command output logs attached for completeness. |
Seems like this is dependency resolving issue. I'll check later today, if it is possible to solve it without loosing prettify output. |
A bit mode details about the problem.
As the result, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It fixes Vue 2.7 bug with dependencies.
Alternative solution: vuejs/vue#13053
Co-authored-by: Grigorii K. Shartsev <grigorii.shartsev@nextcloud.com> Signed-off-by: Christian Wolf <github@christianwolf.email>
I will merge this. Until a new release of Vue2 has been pushed out (and we can use that as a dependency) that was fixed by your PR, we can use this workaround. This can be reverted afterward. |
Currently, the
webpack-loader
runs prettier in development mode. This is the current default. With the updated version of Prettier from 2 to 3, the trailing comma setting changed to all. Unfortunately, thevue-loader
chokes on the additional commas and refuses to build the Vue files.This PR will disable the prettify step during the Vue build for the development build. Thus no issue is triggered for the build with the Vue loader.
This is more of a central fix to prevent others to run into the same issue as me and needing to configure the rules locally in the apps. This is only intended as a temporary workaround until the vue loader can handle the extra commas. As the default codebase would ideally be prettified already, the impact on readability should not be too much.