Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcAppNavigationItem): TypeError: this.$refs.actions.$refs.menuButton is undefined #6226

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

wofferl
Copy link
Contributor

@wofferl wofferl commented Nov 16, 2024

☑️ Resolves

menuButton was renamed to triggerButton in e817174

@@ -1883,7 +1900,7 @@ export default {
                                                        disabled: this.disabled,
                                                },
                                                slot: 'trigger',
-                                               ref: 'menuButton',
+                                               ref: 'triggerButton',
                                                attrs: {
                                                        id: this.triggerRandomId,
                                                        'aria-label': this.menuName ? null : this.ariaLabel,

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

Signed-off-by: Wolfgang <github@linux-dude.de>
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ShGKme ShGKme requested a review from susnux November 16, 2024 15:22
@ShGKme ShGKme assigned ShGKme and unassigned ShGKme Nov 16, 2024
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component labels Nov 16, 2024
@ShGKme ShGKme added this to the 8.20.1 milestone Nov 16, 2024
@ShGKme
Copy link
Contributor

ShGKme commented Nov 16, 2024

Probably, we should add focus exposed method to NcActions

@wofferl
Copy link
Contributor Author

wofferl commented Nov 26, 2024

Probably, we should add focus exposed method to NcActions
@ShGKme
is there anything I can do here or to work around in the app until this is merged/fixed.
Because some users rely on proper tabbing it would nice to have a solution here.
nextcloud/news#2919

@ShGKme
Copy link
Contributor

ShGKme commented Nov 26, 2024

@wofferl It was a thought for follow-ups, I have approved the PR.

@ShGKme ShGKme requested a review from Antreesy November 26, 2024 09:57
@susnux susnux merged commit 32ca57f into nextcloud-libraries:master Nov 26, 2024
15 checks passed
@susnux
Copy link
Contributor

susnux commented Nov 26, 2024

/backport to next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: app-navigation Related to the app-navigation component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NcAppNavigationItem] TypeError: this.$refs.actions.$refs.menuButton is undefined
4 participants