feat: Add spawnDialog function
#6195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
ShGKme
reviewed
Nov 6, 2024
susnux
force-pushed
the
feat/add-spawn-dialog
branch
from
11eaaf2 to
9f1edb6
Compare
ShGKme
approved these changes
Nov 7, 2024
ShGKme
reviewed
Nov 7, 2024
st3iny
approved these changes
Nov 7, 2024
This allows to spawn a Vue dialog without the need of mounting the component. So it is possible to spawn a dialog directly from any JS code outside of components (e.g. callback functions). This method was originally taken from `@nextcloud/dialogs`, but I think it should belong to this Vue components library. Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Grigorii K. Shartsev <me@shgk.me> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/add-spawn-dialog
branch
from
9f1edb6 to
23cabb6
Compare
ShGKme
approved these changes
Nov 11, 2024
|
/backport to next |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
This allows to spawn a Vue dialog without the need of mounting the component.
So it is possible to spawn a dialog directly from any JS code outside of components (e.g. callback functions).
This method was originally taken from
@nextcloud/dialogs, but I think it should belong to this Vue components library.🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade